Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Mark Brown <broonie@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-spi@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 00/22] spi: sh-msiof: Transfer size improvements and I2S reuse
Date: Fri, 16 May 2025 15:32:03 +0200	[thread overview]
Message-ID: <cover.1747401908.git.geert+renesas@glider.be> (raw)

	Hi all,

This patch series (A) improves single transfer sizes in the MSIOF
driver, using two methods:
  - By increasing the assumed FIFO sizes, impacting both PIO and DMA
    transfers,
  - By using two groups, impacting DMA transfers,
and (B) lets the recently-introduced MSIOF I2S drive reuse the SPI
driver's register definitions.  All of this is covered with a thick
sauce of fixes for (harmless) bugs, cleanups, and refactorings.

Changes compared to v1[1]:
  - Make include/linux/spi/sh_msiof.h self-contained,
  - Add Tested-by for the sound part.

Note that the driver uses the limitations as specified in the hardware
documentation.  For discovering the actual FIFO sizes, I wrote some
crude test code that can be found at [2].

This is based on spi/for-next and sound-asoc/for-next, and has been
tested on a variery of R-Car SoCs.

Thanks for your comments!

[1] https://lore.kernel.org/cover.1746180072.git.geert+renesas@glider.be
[2] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/msiof-fifo

Geert Uytterhoeven (22):
  spi: sh-msiof: Drop comma after OF match table sentinel
  spi: sh-msiof: Remove unneeded compatible values
  spi: sh-msiof: Fix maximum DMA transfer size
  spi: sh-msiof: Complete using dev in sh_msiof_spi_probe()
  spi: sh-msiof: Use bool for boolean flags
  spi: sh-msiof: Make words/bits unsigned in sh_msiof_spi_txrx_once()
  spi: sh-msiof: Make words/fs unsigned in FIFO helpers
  spi: sh-msiof: SITMDR1/SIRMDR1 bitfield conversion
  spi: sh-msiof: SITMDR2 and SIRMDR2 bitfield conversion
  spi: sh-msiof: SITSCR/SIRSCR bitfield conversion
  spi: sh-msiof: SICTR bitfield conversion
  spi: sh-msiof: SIFCTR bitfield conversion
  spi: sh-msiof: Correct SIMDR2_GRPMASK
  spi: sh-msiof: Add core support for dual-group transfers
  spi: sh-msiof: Correct RX FIFO size for R-Car Gen2
  spi: sh-msiof: Correct RX FIFO size for R-Car Gen3
  spi: sh-msiof: Increase TX FIFO size for R-Car V4H/V4M
  spi: sh-msiof: Simplify BRG's Division Ratio
  spi: sh-msiof: Double maximum DMA transfer size using two groups
  spi: sh-msiof: Document frame start sync pulse mode
  spi: sh-msiof: Move register definitions to <linux/spi/sh_msiof.h>
  ASoC: renesas: msiof: Convert to <linux/spi/sh_msiof.h>

 drivers/spi/spi-sh-msiof.c     | 357 +++++++++++++--------------------
 include/linux/spi/sh_msiof.h   | 125 ++++++++++++
 sound/soc/renesas/rcar/msiof.c |  94 +++------
 3 files changed, 287 insertions(+), 289 deletions(-)

-- 
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2025-05-16 13:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 13:32 Geert Uytterhoeven [this message]
2025-05-16 13:32 ` [PATCH v2 01/22] spi: sh-msiof: Drop comma after OF match table sentinel Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 02/22] spi: sh-msiof: Remove unneeded compatible values Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 03/22] spi: sh-msiof: Fix maximum DMA transfer size Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 04/22] spi: sh-msiof: Complete using dev in sh_msiof_spi_probe() Geert Uytterhoeven
2025-05-19  1:39   ` Kuninori Morimoto
2025-05-16 13:32 ` [PATCH v2 05/22] spi: sh-msiof: Use bool for boolean flags Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 06/22] spi: sh-msiof: Make words/bits unsigned in sh_msiof_spi_txrx_once() Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 07/22] spi: sh-msiof: Make words/fs unsigned in FIFO helpers Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 08/22] spi: sh-msiof: SITMDR1/SIRMDR1 bitfield conversion Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 09/22] spi: sh-msiof: SITMDR2 and SIRMDR2 " Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 10/22] spi: sh-msiof: SITSCR/SIRSCR " Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 11/22] spi: sh-msiof: SICTR " Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 12/22] spi: sh-msiof: SIFCTR " Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 13/22] spi: sh-msiof: Correct SIMDR2_GRPMASK Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 14/22] spi: sh-msiof: Add core support for dual-group transfers Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 15/22] spi: sh-msiof: Correct RX FIFO size for R-Car Gen2 Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 16/22] spi: sh-msiof: Correct RX FIFO size for R-Car Gen3 Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 17/22] spi: sh-msiof: Increase TX FIFO size for R-Car V4H/V4M Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 18/22] spi: sh-msiof: Simplify BRG's Division Ratio Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 19/22] spi: sh-msiof: Double maximum DMA transfer size using two groups Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 20/22] spi: sh-msiof: Document frame start sync pulse mode Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 21/22] spi: sh-msiof: Move register definitions to <linux/spi/sh_msiof.h> Geert Uytterhoeven
2025-05-16 13:32 ` [PATCH v2 22/22] ASoC: renesas: msiof: Convert " Geert Uytterhoeven
2025-05-20 11:20   ` Mark Brown
2025-06-09  0:02     ` Kuninori Morimoto
2025-05-20 11:05 ` [PATCH v2 00/22] spi: sh-msiof: Transfer size improvements and I2S reuse Mark Brown
2025-06-09 15:39 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1747401908.git.geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=broonie@kernel.org \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox