From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongyang Zhao <hongyang.zhao@thundersoft.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Drake <drake@endlessm.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Matteo Martelli <matteomartelli3@gmail.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Srinivas Kandagatla <srini@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Roger Shimizu <rosh@debian.org>
Subject: Re: [PATCH 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support
Date: Thu, 5 Mar 2026 13:15:51 +0100 [thread overview]
Message-ID: <d5296247-9d68-4004-a068-1484cb1b9183@kernel.org> (raw)
In-Reply-To: <20260305-rubikpi-next-20260304-v1-6-327595a4528a@thundersoft.com>
On 05/03/2026 06:47, Hongyang Zhao wrote:
>
> &apps_rsc {
> @@ -727,6 +755,23 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcs6490/a660_zap.mbn";
> };
>
> +&i2c0 {
> + status = "okay";
> +
> + es8316: es8316@11 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
> + compatible = "everest,es8316";
> + reg = <0x11>;
> + #sound-dai-cells = <0>;
> +
> + clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> + clock-names = "mclk";
> +
> + interrupts-extended = <&tlmm 63 IRQ_TYPE_EDGE_BOTH>;
> +
> + everest,jack-detect-inverted;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-05 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 5:47 [PATCH 0/6] Subject: [PATCH 0/6] Add audio support for QCS6490 Thundercomm RubikPi3 Hongyang Zhao
2026-03-05 5:47 ` [PATCH 1/6] ASoC: dt-bindings: es8316: Document everest,jack-detect-inverted property Hongyang Zhao
2026-03-06 8:10 ` Krzysztof Kozlowski
2026-03-05 5:47 ` [PATCH 2/6] ASoC: es8316: Get sysclk rate from MCLK clock when not explicitly set Hongyang Zhao
2026-03-13 15:28 ` Mark Brown
2026-03-15 5:07 ` Hongyang Zhao
2026-03-05 5:47 ` [PATCH 3/6] ASoC: qdsp6: q6prm: Add MCLK and internal digital codec core clock IDs Hongyang Zhao
2026-03-09 7:41 ` Srinivas Kandagatla
2026-03-05 5:47 ` [PATCH 4/6] ASoC: qcom: common: Add MI2S port IDs to jack setup Hongyang Zhao
2026-03-05 5:47 ` [PATCH 5/6] ASoC: qcom: sc8280xp: Set codec DAI format for MI2S links Hongyang Zhao
2026-03-05 5:47 ` [PATCH 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support Hongyang Zhao
2026-03-05 10:01 ` Konrad Dybcio
2026-03-05 10:51 ` Hongyang Zhao
2026-03-05 12:15 ` Krzysztof Kozlowski [this message]
2026-03-06 4:49 ` Hongyang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5296247-9d68-4004-a068-1484cb1b9183@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=hongyang.zhao@thundersoft.com \
--cc=katsuhiro@katsuster.net \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=matteomartelli3@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=rosh@debian.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox