Re: [PATCH v3 0/4] SDCA System Suspend Support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 1/9/26 15:52, Charles Keepax wrote:
> Add support for system suspend into the class driver, now split
> out into a separate patch chain.
> 
> Where we got to on the previous discussion, was we don't currently
> have any parts requiring download on runtime resume, doing so
> will add noticeable delay to the runtime resume, and we are not
> blocking someone from adding support for firmware download on
> runtime resume in the future. Also as runtime resume is really
> a kernel concept and power rails are primarily controlled by
> ACPI it is quite unlikely anyone will actually power down the
> part on a runtime suspend anyway. So this version of the chain
> still only downloads firmware on probe and system resume.

LGTM, thanks Charles

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
 
> Changes since v2:
>  - Update some error message capitalisation.
>  - Update some kernel doc.
>  - Add a runtime_get to ensure force resume runs the runtime resume.
>  - Correct detection of system suspend in FDL IRQ.
> 
> Changes since v1:
>  - Update SDCA IRQ enable/disable API to be more clear.
> 
> Charles Keepax (4):
>   ASoC: SDCA: Add SDCA IRQ enable/disable helpers
>   ASoC: SDCA: Add basic system suspend support
>   ASoC: SDCA: Device boot into the system suspend process
>   ASoC: SDCA: Add lock to serialise the Function initialisation
> 
>  include/sound/sdca_interrupts.h      |   7 ++
>  sound/soc/sdca/sdca_class.c          |  34 ++++++++
>  sound/soc/sdca/sdca_class.h          |   2 +
>  sound/soc/sdca/sdca_class_function.c | 126 ++++++++++++++++++++++-----
>  sound/soc/sdca/sdca_interrupts.c     |  93 ++++++++++++++++++--
>  5 files changed, 236 insertions(+), 26 deletions(-)
>