From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <tiwai@suse.com>, <perex@perex.cz>,
<amadeusz.slawinski@gmail.com>, <linux-sound@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] ASoC: Intel: avs: Set of streaming fixes
Date: Mon, 27 Oct 2025 15:43:01 +0100 [thread overview]
Message-ID: <dd089b21-571c-41e2-bcea-d666ee7af882@intel.com> (raw)
In-Reply-To: <37a7a6a1-6180-489d-9309-2d576822b4e2@sirena.org.uk>
On 2025-10-27 1:44 PM, Mark Brown wrote:
> On Mon, Oct 27, 2025 at 12:01:03PM +0100, Cezary Rojewski wrote:
>> Small set of patches two of which fix problems observed during shutdown
>> and XRUN scenarios for PCM streaming. These ensure HDAudio HOST stream
>> is reset and re-setup during XRUNs and synchronize avs_dai_fe_shutdown()
>> and period-elapsed work (thread) so that no slab-use-after-free panics
>> occur.
>
> Sorry, this had already made it to the end of my CI pipeline before you
> resent - could you send an incremental patch please?
To be honest, I don't mind either of versions being merged. The
incremental 'fix' is here to silence a warning reported by sparse.
However, the codec->format is used by apps with snd_pcm_format_t anyway
despite documentation (more like a comment really) suggesting otherwise.
Let's leave it as it's right now, in sound/for-next of yours.
Kind regards,
Czarek
prev parent reply other threads:[~2025-10-27 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 11:01 [PATCH v2 0/3] ASoC: Intel: avs: Set of streaming fixes Cezary Rojewski
2025-10-27 11:01 ` [PATCH v2 1/3] ASoC: Intel: avs: Unprepare a stream when XRUN occurs Cezary Rojewski
2025-10-27 11:01 ` [PATCH v2 2/3] ASoC: Intel: avs: Disable periods-elapsed work when closing PCM Cezary Rojewski
2025-10-27 11:01 ` [PATCH v2 3/3] ASoC: Intel: avs: Use snd_codec format when initializing probe Cezary Rojewski
2025-10-27 12:37 ` [PATCH v2 0/3] ASoC: Intel: avs: Set of streaming fixes Mark Brown
2025-10-27 12:44 ` Mark Brown
2025-10-27 14:43 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd089b21-571c-41e2-bcea-d666ee7af882@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeusz.slawinski@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox