From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>
Subject: Re: [PATCH v4 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard()
Date: Mon, 29 Jun 2026 15:25:01 +0200 [thread overview]
Message-ID: <e0a41c2a-3fa1-44d8-afda-71e21d210db8@intel.com> (raw)
In-Reply-To: <CAABR9nGtu83T-_riRpbndPyqbhxQpNrcXU-avy2m1VC-H4_AZg@mail.gmail.com>
On 6/29/2026 3:03 PM, Bui Duc Phuc wrote:
> The only thing I'm still a bit concerned about is splitting the kfree
> and guard() changes into two patches.
> Since the guard() conversion is mainly there to eliminate the goto
> labels, testing them separately might
> introduce issues that wouldn't exist when both patches are applied together.
The CI is run for entire patchset.
> By the way, I'm curious about your CI. What kinds of tests does it cover?
> For example, can it detect regressions related to audio functionality
> only, or is it also able to validate
> audio quality? I imagine things that require someone to actually
> listen to the output would be difficult
> to automate.
Cannot share the details but I'm talking about actual long-term-support
CI with large amount of corporate resources invested. A lab, high
number of physical setups with intention to cover every Intel's AudioDSP
architecture version (starting from Haswell) and streaming-interface
type (HDAudio, DMIC etc.).
All functional tests are fully automated - imitate every single scenario
we do expose for our clients, regardless of the OS type. While again, I
cannot list the tests, the basics are quite simple - bucket the
"functions" e.g.: system states (SXes), device states (DXes),
multi-threading, clocking (the list goes on) and do: atomic test and
then a combination for each feature from each bucket (if valid).
Incomplete example for basic playback:
- 1x default endpoint pb before s3
- 1x default endpoint pb during s3
- 1x default endpoint pb after s3
- 1x default endpoint pb before s4
- 1x default endpoint pb during s4
- 1x default endpoint pb after s4
Wait, does that mean the tests go in thousands? Yeah, several thousands.
However, without such investment, people like me would not be able to
propose and provide reliable contributions for Intel and ASoC both.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-06-29 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 8:28 [PATCH v4 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() phucduc.bui
2026-06-26 8:29 ` [PATCH v4 1/5] ASoC: Intel: avs: Use guard() for locking phucduc.bui
2026-06-26 8:29 ` [PATCH v4 2/5] ASoC: Intel: avs: Use scoped_guard() for scoped locking phucduc.bui
2026-06-26 8:29 ` [PATCH v4 3/5] ASoC: intel: atom: Use __free(kfree) for stream pointer phucduc.bui
2026-06-26 8:29 ` [PATCH v4 4/5] ASoC: Intel: atom: Use guard() for locking phucduc.bui
2026-06-26 8:29 ` [PATCH v4 5/5] ASoC: Intel: atom: Use scoped_guard() for scoped locking phucduc.bui
2026-06-29 8:29 ` [PATCH v4 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard() Cezary Rojewski
2026-06-29 13:03 ` Bui Duc Phuc
2026-06-29 13:25 ` Cezary Rojewski [this message]
2026-06-29 14:26 ` Bui Duc Phuc
2026-06-29 14:51 ` Cezary Rojewski
2026-06-30 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0a41c2a-3fa1-44d8-afda-71e21d210db8@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox