From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca@lucaweiss.eu>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Weidong Wang <wangweidong.a@awinic.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: Document Awinic AW8898 amplifier
Date: Sun, 6 Apr 2025 15:52:28 +0200 [thread overview]
Message-ID: <e1080a50-4728-456c-a1c1-88baaf083ecf@kernel.org> (raw)
In-Reply-To: <20250406-aw8898-v1-1-58a2d554693f@lucaweiss.eu>
On 06/04/2025 15:03, Luca Weiss wrote:
> + description:
> + Digital IO power supply
> +
> + vdd-supply:
> + description:
> + Battery power supply
> +
> + "#sound-dai-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
Some or all of the supplies should be required.
> + - "#sound-dai-cells"
> +
> +additionalProperties: false
and this 'unevaluatedProperties: false' instead.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-06 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 13:03 [PATCH 0/3] Add support for AW8898 Amplifier Luca Weiss
2025-04-06 13:03 ` [PATCH 1/3] ASoC: dt-bindings: Document Awinic AW8898 amplifier Luca Weiss
2025-04-06 13:52 ` Krzysztof Kozlowski [this message]
2025-04-06 13:03 ` [PATCH 2/3] ASoC: codecs: Add aw8898 amplifier driver Luca Weiss
2025-04-06 13:53 ` Krzysztof Kozlowski
2025-04-06 18:28 ` Mark Brown
2025-04-06 13:03 ` [PATCH 3/3] arm64: dts: qcom: sdm632-fairphone-fp3: Add AW8898 amplifier Luca Weiss
2025-04-06 13:54 ` Krzysztof Kozlowski
2025-04-07 8:40 ` Konrad Dybcio
2025-06-17 21:31 ` (subset) [PATCH 0/3] Add support for AW8898 Amplifier Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1080a50-4728-456c-a1c1-88baaf083ecf@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox