From: "Liao, Bard" <yung-chuan.liao@linux.intel.com>
To: I Hsin Cheng <richard120310@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, pierre-louis.bossart@linux.dev,
Vijendar.Mukunda@amd.com, peter.ujfalusi@linux.intel.com,
peterz@infradead.org, christophe.jaillet@wanadoo.fr,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, bard.liao@intel.com
Subject: Re: [RFC PATCH] ASoC: intel/sdw_utils: Assign initial value in asoc_sdw_rt_amp_spk_rtd_init()
Date: Mon, 5 May 2025 20:58:41 +0800 [thread overview]
Message-ID: <e1be89ec-186b-4195-90c2-bd97e50b01f4@linux.intel.com> (raw)
In-Reply-To: <aBizHlY-UxnBsNDs@vaxr-BM6660-BM6360>
On 5/5/2025 8:46 PM, I Hsin Cheng wrote:
> On Mon, May 05, 2025 at 04:27:04PM +0800, Liao, Bard wrote:
>
> Hi,
>
> Thanks for your kindly review!
>
>> The existing name_prefix is with either "-1" or "-2". But we can't make
>> the assumption in the asoc_sdw_rt_amp_spk_rtd_init() helper. We might
>> have "-3", "-4" etc in the future.
>>
> I get it, so in that case we should stick with current implementation
> then. For "ret"'s initial value, do you think "-EINVAL" is ok or do you
> prefer other value to be used ?
-EINVAL is good to me.
> I'll refine commit message and send a formal v2 patch with your
> preference.
>
> Best regards,
> I Hsin Cheng
>
prev parent reply other threads:[~2025-05-05 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 7:41 [RFC PATCH] ASoC: intel/sdw_utils: Assign initial value in asoc_sdw_rt_amp_spk_rtd_init() I Hsin Cheng
2025-05-05 8:27 ` Liao, Bard
2025-05-05 12:46 ` I Hsin Cheng
2025-05-05 12:58 ` Liao, Bard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1be89ec-186b-4195-90c2-bd97e50b01f4@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=peterz@infradead.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=richard120310@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox