From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mithil <bavishimithil@gmail.com>
Cc: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lopez Cruz" <misael.lopez@ti.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema
Date: Wed, 22 May 2024 19:07:34 +0200 [thread overview]
Message-ID: <e384272a-4dfe-4653-8983-6426f8803c84@kernel.org> (raw)
In-Reply-To: <CAGzNGRm5i8zvnXiPzMg5=+tr9oyBcRA8LFvnmgGzE=MzSNTXug@mail.gmail.com>
On 22/05/2024 19:02, Mithil wrote:
>> Yep. And testing DTS should clearly show that conversion leads to
>> incomplete binding.
>>
>>>
>>>> I assume the DTS was validated with the binding. Isn't the case here?
>>
>> Mithil Bavishi,
>> Are you sure you tested the DTS?
>
> dt_binding_check did not give me any errors. Yeah the example is
> different from how it is implemented in the kernel ie board specific
> (omap4, omap5 etc). Should the example be changed according to that
> dtsi then?
Binding needs to be adapted to match DTS or DTS has to be fixed to match
binding, depending which one is correct. Mention any changes done in the
binding which deviate from pure conversion of TXT->DT schema.
https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-22 17:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 7:52 [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Mighty
2024-05-22 8:42 ` Krzysztof Kozlowski
2024-05-22 13:46 ` Mithil
2024-05-22 14:15 ` Krzysztof Kozlowski
2024-05-22 13:56 ` Péter Ujfalusi
2024-05-22 14:16 ` Krzysztof Kozlowski
2024-05-22 14:43 ` Péter Ujfalusi
2024-05-22 15:22 ` Krzysztof Kozlowski
2024-05-22 16:01 ` Péter Ujfalusi
2024-05-22 16:42 ` Krzysztof Kozlowski
2024-05-22 17:02 ` Mithil
2024-05-22 17:07 ` Mithil
2024-05-22 17:07 ` Krzysztof Kozlowski [this message]
2024-05-22 17:30 ` Mithil
2024-05-22 17:47 ` Mithil
2024-05-22 18:49 ` Péter Ujfalusi
2024-05-22 18:39 ` Péter Ujfalusi
2024-05-23 6:08 ` Krzysztof Kozlowski
2024-05-22 14:22 ` Rob Herring
2024-05-22 14:39 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e384272a-4dfe-4653-8983-6426f8803c84@kernel.org \
--to=krzk@kernel.org \
--cc=bavishimithil@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox