Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Alexander Kaplan <alexander.kaplan@sms-medipool.de>
Cc: "Péter Ujfalusi" <peter.ujfalusi@intel.com>,
	"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	linux-sound@vger.kernel.org, "Jaroslav Kysela" <perex@perex.cz>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
	stable@vger.kernel.org, "Uma Shankar" <uma.shankar@intel.com>
Subject: Re: [PATCH] ALSA: hda/hdmi: disable KAE for Intel Panther Lake
Date: Tue, 16 Jun 2026 22:13:47 +0300 (EEST)	[thread overview]
Message-ID: <e5a56b3c-1fd7-35ad-f072-e490e2b471a9@linux.intel.com> (raw)
In-Reply-To: <20260612181314.5577-1-alexander.kaplan@sms-medipool.de>

Hi Alexander,

On Fri, 12 Jun 2026, Alexander Kaplan wrote:

> That is probably just the sink.
> As long as KAE was never active in the display power cycle, my TV plays multichannel LPCM audibly on the front pair, even though its ELD advertises 2 channel LPCM only.
> The bug signal is the switch to multichannel itself.
> The first 6 or 8 channel stream after KAE activity plays silent, wedges the pin and everything after it stays silent.
[...]
> That said, after your LNL result I agree a PTL only model change is the wrong shape.
> I can gate the silent stream type per pin on the ELD connection type instead.
> DP pins fall back to the SILENT_STREAM_I915 path and native HDMI pins keep KAE, on all KAE platforms.
> That matches the failure boundary on both of our machines and keeps the power benefit where it works.
> If that shape works for you I will send it as v2.

gating on DP pin type is less than ideal as this would impact USB-C dock
usage, which is probably the most common scenario where the display audio 
keepalive helps (to ensure desktop/UI sounds are played out from the start 
and not eaten up by the HDMI/DP receiver taking their time waking up).

I'm asking around internally for more test results based on your findings, 
but one quick test to make if you have time:
--cut--
--- a/sound/hda/codecs/hdmi/intelhdmi.c
+++ b/sound/hda/codecs/hdmi/intelhdmi.c
@@ -445,6 +445,12 @@ static int i915_hsw_setup_stream(struct hda_codec *codec, hda_nid_t cvt_nid,
                                        stream_tag, format);

        if (spec->silent_stream_type == SILENT_STREAM_KAE && per_pin && per_pin->silent_stream) {
+               /* do not reenable KAE if multichannel streaming started */
+               if ((format & AC_FMT_TYPE_NON_PCM) || (format & AC_FMT_CHAN_MASK) > 1) {
+                       codec_dbg(codec, "HDMI: multichannel stream, disable KAE\n");
+                       return res;
+               }
+
--cut--

The driver has disabled KAE just before this, so this is worth a shot. 
If pin is still wedged, then the problem occurs already earlier in the 
sequence.

Br, Kai

      reply	other threads:[~2026-06-16 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 17:48 [PATCH] ALSA: hda/hdmi: disable KAE for Intel Panther Lake Alexander Kaplan
2026-06-11  9:08 ` Péter Ujfalusi
2026-06-11  9:33   ` Péter Ujfalusi
2026-06-11 14:44     ` Alexander Kaplan
2026-06-12 12:45       ` Péter Ujfalusi
2026-06-12 18:13         ` Alexander Kaplan
2026-06-16 19:13           ` Kai Vehmanen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5a56b3c-1fd7-35ad-f072-e490e2b471a9@linux.intel.com \
    --to=kai.vehmanen@linux.intel.com \
    --cc=alexander.kaplan@sms-medipool.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@intel.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox