From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CB9234B1B2 for ; Tue, 21 Oct 2025 19:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761073938; cv=none; b=FXIIRC5sdPgWEgcPc35yBFAdO4+EP5qKjZB4GjVWP2GUCvHrqBnLkAOHP46noRWegfJvcg6H8CIaSc2rTdkozYiJZ5Zz56KgSDUXciplq1dNI2onEWSYQYb0mVCAG/PLb+ghzI8oJcazFAOm1U1kYWL8eWJkVQmwaHO+CkuwZJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761073938; c=relaxed/simple; bh=hstBXS/TVUOaaiIRmLPtbLaaswkp/Zt78i4TpWCCmEw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZljrKechhDGxZeQ1aTmeYl/7PXRczzFs+ZIZLLoAxnu2bL3HmevaIF7XO7I6ln4i6Vtgek5dXbctDH8VFpSYZ29rFUAKespGJQycvj/m2elFh/BkiWJ9/Xx/RDJj6LaIRQzy1Nb2QT7O7zbfTA36wg+3zTrF+iq0ypuKVOHJb68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KrlaPjw/; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KrlaPjw/" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-63e18829aa7so212996a12.3 for ; Tue, 21 Oct 2025 12:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761073935; x=1761678735; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=hstBXS/TVUOaaiIRmLPtbLaaswkp/Zt78i4TpWCCmEw=; b=KrlaPjw/zw83E0ZbRGZ0Td1jS6BrwjCH6V1EXhGzJF/Writem6G3OOPRA1cx4kzrDC uP2sHV+R58D51KsXZEc9Wm0rp6q4cdHKl8t5mbztfxbpy6KGhal5lG5mqd0KHu+6u2qI 6pUDBWgh+DLkX61WWTOVbHkWXu2n0z/jrw/TcHvHTpa9SlpUtO9YIAMWjYo5NnYHhuQn nB0bWhkFTSOb6kY2VYBFxKAnzfjF0pJcYb+UDbGxYpP6hN9WdnsRklvxVqnnCxj7Y72a TPKKnVwAwMGGQVwMkKtLN6YqJdYUWHCL75OHVbLmafpIbda6fzGD/eNAlhuGL7Z86FIj nfHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761073935; x=1761678735; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hstBXS/TVUOaaiIRmLPtbLaaswkp/Zt78i4TpWCCmEw=; b=Ee15dajLB++NcmgMWQPLF2K3y7i4ZpDqHanjKpTiiNEhx/qUjKx9AU0QueVM06btI7 4bz6smm1Iplp7dJPbxFREJgtQAnWx971ILrTSa8ZCYhcfca9LekOnSxuvPsC/RrUh1dJ X78A7v93O//W26MzrCtQQg7t2MYbNCJ/ECPULqMtBRSlSQ3UyEOi/Ppywdk49qMWOFPg OnD2HE7rncZ5gH0h82QtCdus6R05WsslG0lZjLcNNL+T6iwjDCIGekkZ+8hZ8BG0WWGb J3g0SynZlMvYwZF6RmmklBf/MUgudYnutPXNQGNTiU1BN5r+GpYvM7tUqI2eCvs0LmBE eleA== X-Forwarded-Encrypted: i=1; AJvYcCVoltZ92XpxNdrxsET0nBn524pE2PxgZGpjGzRGcUD9l+m/AoD/P56hpTiY/6hJ3wnRi8YG09s67/sLwg==@vger.kernel.org X-Gm-Message-State: AOJu0YyuECEbdwRPtaTDXsrUuV65ubcZ1kklliIJE71NPKYbKlFzAXFX zZcG8ZpKUKGsDdvunERCKrXiys9afZz5psyLiSwXbmCmSmU0XLZNb3TM X-Gm-Gg: ASbGncsHMeUoV1sZOp41D1XlAtNmcCLBOQPI+n3TdoORJYBOsPfFAP9ejKj1gcXBnNb wVMoZ+EHRSgDCvIGVVE8fmFm3gqYBaiwiVUUv8VNk6aMoL0v181shActu4k6KRZgZG6aEJASznp MFMafhol/5LsZsgNAJOqv7Z4JmaI4xd75JjswIjLFUggqSXCvyqSpl8k2B6myMq1fqvrQ7eQLKC 49G7fagxCoYEs757OyLYcNIVenkrhRHURNnSh8QC8x6AS1XsdYdp9wgAG2PPJBe2u4aa4lkrtPf BD5wWWDAPel5n3z1jdyQuTNGraHEeS+t6zQSMDbuB0+XL4qiqAC4F0PPi+B/2COrSujIU3ejlzB 63HQ87JkXb7HWxMcXc+bjnNnC83pQEo6pPxCHcECNZGdsIS4WYtcVtjhntP2Vt9BBSr0cx/Rek7 nEsOgevlvVROGkDN30bHGbuoF00t8IKF40fLlJDnECiOi9VkN2B2IERSDq X-Google-Smtp-Source: AGHT+IF/mcKyBnV5vQ1RTt10Y+TO7vaXwW267VWXkDS1GyTMV+9b8aBDdkZD6aV3L8pfV3t1oFBifw== X-Received: by 2002:a05:6402:1d49:b0:63c:43e6:16f7 with SMTP id 4fb4d7f45d1cf-63c43e618d3mr16489930a12.26.1761073935222; Tue, 21 Oct 2025 12:12:15 -0700 (PDT) Received: from 0.1.2.1.2.0.a.2.dynamic.cust.swisscom.net ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63c4945ef35sm10305713a12.28.2025.10.21.12.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 12:12:14 -0700 (PDT) Message-ID: Subject: Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers automatic module loading From: Alexander Sverdlin To: Mark Brown Cc: Javier Martinez Canillas , Wolfram Sang , Herve Codina , David Rhodes , Richard Fitzgerald , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Nikita Shubin , Axel Lin , Brian Austin , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Date: Tue, 21 Oct 2025 21:12:13 +0200 In-Reply-To: <42f11845-35f2-40e0-b860-c25ba6f8d503@sirena.org.uk> References: <20251016130340.1442090-1-herve.codina@bootlin.com> <20251016130340.1442090-2-herve.codina@bootlin.com> <60fbaaef249e6f5af602fe4087eab31cd70905de.camel@gmail.com> <20251017083232.31e53478@bootlin.com> <4b851d47bf1d03988a27671ae21208cdeed76837.camel@gmail.com> <5f2aeb66-97d6-41b7-8c80-87674c1b14d8@sirena.org.uk> <42f11845-35f2-40e0-b860-c25ba6f8d503@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Mark! On Tue, 2025-10-21 at 20:00 +0100, Mark Brown wrote: > On Fri, Oct 17, 2025 at 08:14:43PM +0200, Alexander Sverdlin wrote: >=20 > > "Reparing" them as Herve proposed would result in I2C modules being > > loaded only via "of:" style modalias and SPI still via "spi:". Which > > sounds all but consistent. >=20 > > If SPI ever adopts the same of_device_uevent_modalias(), both backends > > would require "of:" prefixed modalias, and it will not be possible to > > load the proper one for the corresponding bus type. >=20 > > What are your thoughs on this? >=20 > Or at least you'd get both modules loaded with one being redundant.=C2=A0= TBH I'm quite confident that udev/modprobe will load only the first module from modules.alias file. > I'm very reluctant to touch this stuff for SPI without some very careful > analysis that it's not going to cause things to explode on people, right > now things seem to be working well enough so I'm not clear we'd be > solving an actual problem. The actual problem is that i2c-core is producing "of:" prefixed uevents instead of "i2c:" prefixed uevents starting from v4.18. Most of the dual-bus ASoC CODECs are affected. Now declaring "of:" to be the new I2C bus prefix for uevents starting from Linux v4.18 sounds strange. --=20 Alexander Sverdlin.