From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
<linux-sound@vger.kernel.org>, <vkoul@kernel.org>
Cc: <vinod.koul@linaro.org>, <linux-kernel@vger.kernel.org>,
<pierre-louis.bossart@linux.dev>, <bard.liao@intel.com>
Subject: Re: [PATCH v2 07/14] Soundwire: stream: program BUSCLOCK_SCALE
Date: Tue, 3 Dec 2024 13:51:37 +0000 [thread overview]
Message-ID: <e888ffb4-90a6-41d4-b081-e084b09b3780@opensource.cirrus.com> (raw)
In-Reply-To: <20241203131813.58454-8-yung-chuan.liao@linux.intel.com>
On 3/12/24 13:18, Bard Liao wrote:
> We need to program bus clock scale to adjust the bus clock if current
> bus clock doesn't fit the bandwidth.
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> ---
> drivers/soundwire/bus.c | 10 ++++++++++
> drivers/soundwire/stream.c | 32 ++++++++++++++++++++++++++++++++
> include/linux/soundwire/sdw.h | 1 +
> 3 files changed, 43 insertions(+)
>
Does this still have the bug I reported here that breaks on systems
that have peripherals listed in ACPI that don't really exist?
https://github.com/thesofproject/linux/issues/5257
next prev parent reply other threads:[~2024-12-03 13:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 13:17 [PATCH v2 00/14] soundwire: add multi-lane support Bard Liao
2024-12-03 13:18 ` [PATCH v2 01/14] soundwire: add lane field in sdw_port_runtime Bard Liao
2024-12-03 13:18 ` [PATCH v2 02/14] soundwire: mipi_disco: read lane mapping properties from ACPI Bard Liao
2024-12-03 13:18 ` [PATCH v2 03/14] soundwire: add lane_used_bandwidth in struct sdw_bus Bard Liao
2024-12-03 13:18 ` [PATCH v2 04/14] soundwire: stream: set DEPREPARED state earlier Bard Liao
2024-12-03 13:18 ` [PATCH v2 05/14] soundwire: generic_bandwidth_allocation: skip DEPREPARED streams Bard Liao
2024-12-03 13:18 ` [PATCH v2 06/14] Soundwire: add sdw_slave_get_scale_index helper Bard Liao
2024-12-03 13:18 ` [PATCH v2 07/14] Soundwire: stream: program BUSCLOCK_SCALE Bard Liao
2024-12-03 13:51 ` Richard Fitzgerald [this message]
2024-12-04 2:44 ` Liao, Bard
2024-12-03 13:18 ` [PATCH v2 08/14] Soundwire: generic_bandwidth_allocation: set frame shape on fly Bard Liao
2024-12-03 13:18 ` [PATCH v2 09/14] soundwire: generic_bandwidth_allocation: correct clk_freq check in sdw_select_row_col Bard Liao
2024-12-03 13:18 ` [PATCH v2 10/14] soundwire: generic_bandwidth_allocation: check required freq accurately Bard Liao
2024-12-03 13:18 ` [PATCH v2 11/14] soundwire: generic_bandwidth_allocation: select data lane Bard Liao
2024-12-03 13:18 ` [PATCH v2 12/14] soundwire: generic_bandwidth_allocation: add lane in sdw_group_params Bard Liao
2024-12-03 13:18 ` [PATCH v2 13/14] SoundWire: pass stream to compute_params() Bard Liao
2024-12-03 13:18 ` [PATCH v2 14/14] soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e888ffb4-90a6-41d4-b081-e084b09b3780@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox