Re: [PATCH v2 21/24] ASoC: SOF: ipc4: Handle compressed drain done notification from firmware

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 9/9/26 11:09, Peter Ujfalusi wrote:
> The decoder module sends a drain done notification when the last chunk of
> the stream after the EOS from host has been decoded.
> 
> The notification is a module notification with 0xc0c0 as magic number in
> event_id upper 16 bit.
> 
> Call sof_ipc4_compr_drain_done() when the notification arrives to handle
> it.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
> ---
>  include/sound/sof/ipc4/header.h |  3 ++-
>  sound/soc/sof/ipc4.c            | 13 +++++++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/include/sound/sof/ipc4/header.h b/include/sound/sof/ipc4/header.h
> index dd1e0d1cf0d8..c0216f4b14c2 100644
> --- a/include/sound/sof/ipc4/header.h
> +++ b/include/sound/sof/ipc4/header.h
> @@ -647,9 +647,10 @@ struct sof_ipc4_notify_module_data {
>   * The event_data contains the struct sof_ipc4_control_msg_payload of the control
>   * which sent the notification.
>   */
> -#define SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_MASK		GENMASK(31, 16)
> +#define SOF_IPC4_NOTIFY_MODULE_EVENTID_SOF_MAGIC_MASK		GENMASK(31, 16)

not clear why you have to rename the MASK but not the VAL?

>  #define SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_VAL		0xA15A0000
>  #define SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_PARAMID_MASK	GENMASK(15, 0)

<dad joke> always stay away from paramid schemes </dad joke>
> +#define SOF_IPC4_NOTIFY_MODULE_EVENTID_COMPR_MAGIC_VAL		0xC0C00000

maybe just add this one and avoid the confusing rename above?

>  
>  /*
>   * Macros for creating struct sof_ipc4_module_init_ext_init payload
> diff --git a/sound/soc/sof/ipc4.c b/sound/soc/sof/ipc4.c
> index e77f73390bd8..b9dd798e59bc 100644
> --- a/sound/soc/sof/ipc4.c
> +++ b/sound/soc/sof/ipc4.c
> @@ -776,12 +776,21 @@ static void sof_ipc4_module_notification_handler(struct snd_sof_dev *sdev,
>  	}
>  
>  	/* Handle ALSA kcontrol notification */
> -	if ((data->event_id & SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_MASK) ==
> -	    SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_VAL) {
> +	switch (data->event_id & SOF_IPC4_NOTIFY_MODULE_EVENTID_SOF_MAGIC_MASK) {
> +	case SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_VAL:
> +	{
>  		const struct sof_ipc_tplg_ops *tplg_ops = sdev->ipc->ops->tplg;
>  
>  		if (tplg_ops->control->update)
>  			tplg_ops->control->update(sdev, ipc4_msg);
> +
> +		break;
> +	}
> +	case SOF_IPC4_NOTIFY_MODULE_EVENTID_COMPR_MAGIC_VAL:
> +		sof_ipc4_compr_drain_done(sdev, ipc4_msg);
> +		break;
> +	default:
> +		break;
>  	}
>  }
>