From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
linux-sound@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the sound-asoc tree
Date: Mon, 8 Apr 2024 15:56:21 +0200 [thread overview]
Message-ID: <ef3dfc2a-fe7d-468f-828e-a97ee30f7549@intel.com> (raw)
In-Reply-To: <ccfe882c-652d-45d2-a9e3-d320ebe01834@sirena.org.uk>
On 2024-04-08 2:28 PM, Mark Brown wrote:
> On Mon, Apr 08, 2024 at 02:12:16PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the sound-asoc tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>
> Copying in Amadeusz and Cezary, this is from the recent AVS changes.
Hello Mark,
Sorry for the trouble caused by one of my changes. I've replied earlier
today in this very topic and provided a patch [1] which I believe
addresses the problem properly.
[1]:
https://lore.kernel.org/alsa-devel/20240408081840.1319431-1-cezary.rojewski@intel.com/
>>
>> In file included from include/linux/bits.h:22,
>> from include/linux/gfp_types.h:5,
>> from include/linux/gfp.h:5,
>> from include/linux/slab.h:16,
>> from sound/soc/intel/avs/icl.c:9:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct avs_icl_memwnd2) == 65536"
>> 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>> | ^~~~~~~~~~~~~~
>> include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
>> 77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
>> | ^~~~~~~~~~~~~~~
>> sound/soc/intel/avs/icl.c:73:1: note: in expansion of macro 'static_assert'
>> 73 | static_assert(sizeof(struct avs_icl_memwnd2) == 65536);
>> | ^~~~~~~~~~~~~
>>
>> Caused by commit
>>
>> c2b10acb62c1 ("ASoC: Intel: avs: Add assert_static to guarantee ABI sizes")
>>
>> PAGE_SIZE is 64K for this build.
>>
>> I have applied this patch for today:
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Mon, 8 Apr 2024 13:50:53 +1000
>> Subject: [PATCH] ASoC: Intel: avs: stop building when PAGE_SIZE == 64K
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>> sound/soc/intel/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
>> index 4b9e498e3303..abe5cba82d50 100644
>> --- a/sound/soc/intel/Kconfig
>> +++ b/sound/soc/intel/Kconfig
>> @@ -211,7 +211,7 @@ config SND_SOC_INTEL_KEEMBAY
>>
>> config SND_SOC_INTEL_AVS
>> tristate "Intel AVS driver"
>> - depends on X86 || COMPILE_TEST
>> + depends on X86
>> depends on PCI
>> depends on COMMON_CLK
>> select SND_SOC_ACPI if ACPI
>> --
>> 2.43.0
>>
>> --
>> Cheers,
>> Stephen Rothwell
>
>
prev parent reply other threads:[~2024-04-08 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240408141216.3eb1128c@canb.auug.org.au>
2024-04-08 12:28 ` linux-next: build failure after merge of the sound-asoc tree Mark Brown
2024-04-08 13:56 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef3dfc2a-fe7d-468f-828e-a97ee30f7549@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox