From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78C126D4C1; Mon, 1 Dec 2025 11:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588642; cv=fail; b=CiQjhpaW6T19xRZzGgNMqkB5ISMcs9emocBbarji99nzoMqbVRk9SxL0A+f53ikNEz1pp2iRQGICJfKrUPTsmCYACFFarUjBW4troWhF7bfDIypm6VrnuXyw9/f7oXM8YD8xe/RbtCPt7G2zk0TLyHxyXkyeLsaiKLa6MYXL3N0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588642; c=relaxed/simple; bh=e3ceT0Dz/eEfYrrLlrpOTF4SHB2SWY1HhNQxU5bQfzQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=C6aBDJS4zE1qqPfv3mhyXWTw/RVb7jq8/bWP04vvP76c+WxlStJCjhUr2+ZHUQVjGUJ7XfuiqoR1oDYFB1qp6hZClIsl7+9f9kPc3NpPlQWPzIj3ZdQHxQVFp97crj56Uh7Vp30B+lJr/+VH1jYdg4B6q94crKkjElC/qmAKafs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=GhZTAc8R; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=qyNCdPpS; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="GhZTAc8R"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="qyNCdPpS" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B15j1Zj817240; Mon, 1 Dec 2025 05:30:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=c+en+vnbuQ5HsWvjhqbnfkLAz+x8x03BMlBpGrwQIQU=; b= GhZTAc8RTPnqfQfFwTOeRsYomhmETAbIBwTCx80lf3rwa3fHolYZDFUWdWrr3jRy fJpC4Y2kzAbDmMdkFEaAugyhQwqMcGrw62cEwko8/CXhSB+ocC3lHNlgL/0Bk4XQ 8ezdAxLDmeUiU/t7qbVUyrsar4eaQu3sKgdRkys7Yyvv6Mt1gQAoa96HuO0X6X98 1XNWI6siTwkJDG2sOaaxYn0qAQtdpk2xLorEeeiM6DsH1bKbjn2+NQKRtQv1y9ts dRkSMmw7iEKqFGzuRWkMLj8l4ZoBRSHwhLwAA8LIH4LuxWp2cZkwANRwkmCTY/4J fnsB8h/5/jrK5JaE6f4wbQ== Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020122.outbound.protection.outlook.com [52.101.85.122]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4aqy441r7n-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 01 Dec 2025 05:30:37 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e+nZU8fNx0ns1xsq2QgYRqd6T2D0AEtQyqOGtTSvqGji4J728dEr6iSDCBEGDDoOw9sZpJiGGeZ9MeHS7ED1uTm3WM5UlpPoBFIZW0d9xLD043t1Sutr+6I649g3GrVNyYeFIOoyrQt/xvN3VAThkS9vxHfi2R8XdMrMsOdiz5Fn6wBGJyl+lbtkkQizMLoX3cT91D5XwQTawztd7tn9cxhpWaJDup4CnanjWWbQSzKZ1ax5Fy/2dTsq/Wwksn7zlEgXJUpSwXUCMv2al6VuqzMTYXanm98jYiZNpF8A7RE+fg7fbUP4RHWdzj6CFnmiF+v2S4LtUR5wXLAKF7XfAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+en+vnbuQ5HsWvjhqbnfkLAz+x8x03BMlBpGrwQIQU=; b=KUMFlMIclYERDLbUdohOlwEJcVEsRWU1ZuHJRFu4SPKaZ1UOusxkYC4V7Ydsve9GAdrzIFvOkk3vFruHxMCnnBCQwss6UCf77+EdL8nqHGLLdSStsMUbLm+aVbpTnsM7beNZY4I6bJdTeOBkhzU+SH336MmyAZ/P4dQJv3dEtMgXAzpFhYVUdaXc0BnVUEdHH4U7lP6lTugyQNzoHRhkzj2HUEu5d4XR+nBiX75Ar2IhpwYvtQVtaCnbRJXCny3hSLFaaKTqDwiCt5I7CUUHNwDbx8r3rBbUIvyt8Lmu3ntQm3unmLD4lUvVvC6G61uI6KdMGuzNPiVdT5ATvxMEhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c+en+vnbuQ5HsWvjhqbnfkLAz+x8x03BMlBpGrwQIQU=; b=qyNCdPpSIuwTdO92YPaJ1I4Urb30/cFPNRyeMixjRkRC3Wpl3xO9lk6t8LfPn7KV1H9pvGQhATgemmxOOzD9S0D1Y5FO4CpoOowyTrx+0+A7FAT9CGcdj2hQOyqhYXaNvAc21qLE64TZju7rNFqKvBwygzuDR171Q3B27kWmmNE= Received: from MN0PR04CA0025.namprd04.prod.outlook.com (2603:10b6:208:52d::24) by IA1PR19MB7685.namprd19.prod.outlook.com (2603:10b6:208:3fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Mon, 1 Dec 2025 11:30:34 +0000 Received: from BL02EPF0002992C.namprd02.prod.outlook.com (2603:10b6:208:52d:cafe::f1) by MN0PR04CA0025.outlook.office365.com (2603:10b6:208:52d::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.17 via Frontend Transport; Mon, 1 Dec 2025 11:30:22 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF0002992C.mail.protection.outlook.com (10.167.249.57) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Mon, 1 Dec 2025 11:30:33 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id C680C406541; Mon, 1 Dec 2025 11:30:31 +0000 (UTC) Received: from [198.90.208.24] (ediswws06.ad.cirrus.com [198.90.208.24]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id AEB7D82254A; Mon, 1 Dec 2025 11:30:31 +0000 (UTC) Message-ID: Date: Mon, 1 Dec 2025 11:30:31 +0000 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: cs-amp-lib: Use __free(kfree) instead of manual freeing From: Richard Fitzgerald To: Krzysztof Kozlowski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Mark Brown References: <20251127155817.1374079-1-rf@opensource.cirrus.com> <8f889b72-479c-46fb-a8cf-c9abfc491463@kernel.org> <8f6f1dc9-8b14-442c-8999-934ac312a1bd@opensource.cirrus.com> Content-Language: en-GB In-Reply-To: <8f6f1dc9-8b14-442c-8999-934ac312a1bd@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992C:EE_|IA1PR19MB7685:EE_ X-MS-Office365-Filtering-Correlation-Id: a561c6a1-a6fd-4a72-d287-08de30cd0a6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|61400799027; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YXRnZEJpQk5DN0sxNW5OeXZoWFBGKzlWeG1mNWs4ZHRqT214Y1JEUmRFbnBm?= =?utf-8?B?L2E4RVpIVEpqaFFGSk5RM1JHUGxwV3ZleVg1bjFCWk81Sk90TVFiTHZDdHdw?= =?utf-8?B?VytNTGpxa3A4MFZkKzYwK0t2RmdiRWlaQ0p3TFplbVJMQ0lQUkpLSWpLZ0V1?= =?utf-8?B?dWRQVGxtMXNrYWtRcG52c1JyamdZbDRobnE0d2JxSnNTT2ZFL085blFRWkdP?= =?utf-8?B?UlplUGdSWnlOaitpZUxrV3RFYUpJOXFGV25ka2JGakRxbU1HalZqVFlqT3ZD?= =?utf-8?B?UjA3THFPWkhFRjcrZVBrZXcwaDFuSGQxVWVWSnR1ck4rY2wvQWJhMzJJc2V4?= =?utf-8?B?STY2c1NRNm91Rmx5cVJLc0ExS2Q1Snh6d3I3dDVpcEtqeGxqOWMzci9LUUMx?= =?utf-8?B?TDBlemlOclJyemY3aTJTZnRCbUJPTTRHb0xwOUFaV0FkWjQvbmczRStUempy?= =?utf-8?B?SzUvOWFyQ1Z2OWZSUEdWRm1YVHhwRDY2ZEJzZ3VKRHdHb2sxbmxDZGxSZGZB?= =?utf-8?B?aUtVQ3lRMFN5UGtIYUwwUk91SHRKWVVPMHdFZnFKVVdQYWcvR0FvWlI0bFBw?= =?utf-8?B?bDBDMENiTk0wdEJSVG9UMWxOWkpNb2U2RERKelE4MEVQQU9JUjJDdWlMMEQ3?= =?utf-8?B?Y2ViaTE4OWg4UmtoNEFIdm9kQkYzendSZGN6MCtTNVFwYlJrMk5hWGdMN2k1?= =?utf-8?B?UmpQb2xKbGhQTDg3V1BvSll5OFUwYklJc1Y3MVJjR3owcDVRcUNCdmRtTEV0?= =?utf-8?B?VXQ1Q1g4MHVVT3hEVnVKY1I2dzlNUm9kQU5kQlQ2TUQwL3Q5ZGttVGRxaGlD?= =?utf-8?B?ZlBPZlJqR2U5TTllb3RWNkYwZlRFUDkwOG5pYi9JMkdTTTcrZGxMZEhReExJ?= =?utf-8?B?bzM3RnVnTjJRR3BoVytzSnVFWGh1UUFDSVk2U053aFNPS0svM2dmLzNMOTRP?= =?utf-8?B?bjl1OFk1Z29ReEtpRVdIbk83Wm9ER3Bra29HSkdwSkcyS1ZpNXAwY1U0M3F2?= =?utf-8?B?VzN0Wjcvc3RIMGVkeVNOYms2STZMK3ZsaG1KTlFRSXovZWRISDhTakJYRGFX?= =?utf-8?B?bnhUdENjWm5GYm1TYkVWZXJzcDJYd0t1dXpBVHR4TllMSFl4cFJNeS9HZTJ6?= =?utf-8?B?YStMaUF2RjZ1SmRaL3VDMFdkNW94MmphcTYrQTRZWGRJTllhNDVBekdRTnUv?= =?utf-8?B?VXFCVFBKdnlLMWlMOGdJSUtXeWU3VjdYN3lTdTFaK2tGWkRvR3ZqbmMzTllO?= =?utf-8?B?TlUwa2RxSGJrVTBoWmNFOGhEQWs2NW1PNkdwZXNyaWxBaXFBaG1QclpiVU9W?= =?utf-8?B?VEJwMHl2dUxWYTdoSHpNR3ZWcDF0RUFiQVgzWEVGU2V5WFZiZXV3NHRMeDRJ?= =?utf-8?B?SFhiNG1COHliZThjYXN0NWZLTmVKbml6S2I3RjZOTWk4dEU2RE8zeXg5UWp4?= =?utf-8?B?dGhWWHhiSEhmdHBIZDRsSHlxSklWTmJxZnVjVm9IN3NmQWhPbHk2UHhRZjBq?= =?utf-8?B?RGVmQVNQQjFKLzhMWEpHalNVNU5JMUlEaG5RNUZIclMwUXVHNlBYUTNMdUM0?= =?utf-8?B?cmVEV2dzRHNzNnk1eWRReHpXS29hS0tGRS8yNFZGbHJDQXQwZ1owYWJjbWhr?= =?utf-8?B?Tk42Y2xRRFhSdmhpUnltS0s1VE5DUDlFOHdENHdHeHZNc3FNK2RSeWNWL1F1?= =?utf-8?B?WjB5c2svN0k5WGZNZmtxWHhGYVZpejAvWVRBUnlGZGFKV2lmalFvdENjTGo1?= =?utf-8?B?WDZUclIyYTd6a05oclZ5NWNYa2dnam04R3Q4eG1jazZNOTZITjVWRzk5dWxQ?= =?utf-8?B?VVNRajFlSUxiYTB6d2g2UjZsOThKMVY3dGN5UFg4TFhMWUlKVVVHMmkvTUxT?= =?utf-8?B?Zk8rcFBCUVBoVVUrZ3ZOWDQ4T0dMYUVqazZldzUxdWowSlcxb29IcGg5YXpL?= =?utf-8?B?Zjd6TU5FOERKb3dCRG94MU11dGM4NEhkOGJOZ1lXa05vSTRwckl1VkFuSzlC?= =?utf-8?B?U0trd2lZRWo2NG1kVnZZNmJpelhaejcrSmw2SWNPdzFoK0JWRE96Vjc5MGds?= =?utf-8?B?RzJWWXZRbTFFZmNCWmROQ2dybXN2R1UydFV4dkpFNjM1eUxFbURFaWlFS2JN?= =?utf-8?Q?UReI=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(61400799027);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2025 11:30:33.2597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a561c6a1-a6fd-4a72-d287-08de30cd0a6f X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL02EPF0002992C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR19MB7685 X-Proofpoint-GUID: ZzzEPHNZDezu7zNHLofErQOmxAur9Kzm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDA5MyBTYWx0ZWRfX0aeHI34m3SBe mzMckxFdbQ1Z+ilL6XcwTGUod3uI+01l1DgvH12wN+0ETz1r1RcbHCSFx5H2SEm8WdbEmlU6i0Z iiRpxi0Iwx9AKHoCFTqCvtiIqD9dGuFRi7RzKQ+wuCY09qdaLrQzY4VlqQbsFUYlpRSum5f/s/q nfyjL3SOJrMFCoBcfrM7rTCT/ZqnO4Cl3eUUTuiKnbsZkpTAxRx3AHp0lTFnFdvKD//QGXApq4Z amUkB3QoStJSQPY0Sfem+DydLnOzbWbJLbjSEMzrPufZnKst9X+oY/Cz1L5P1xVhMmF+Nr4cmA3 TlULjZBWyIYmiYVsHZfDNJUHn411ZliUqIkhrqC1zL8Cj99yArspZeE09hKBQG1aDz8ZX8lWT3d /DCT4QHg8djwhIbLSDwBwCN1imEjMg== X-Authority-Analysis: v=2.4 cv=FK4WBuos c=1 sm=1 tr=0 ts=692d7c5d cx=c_pps a=Qdo7Ea4lwGWRD8/XiwST5A==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=w1d2syhTAAAA:8 a=IM3k0msw5rsS_jjLBuoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: ZzzEPHNZDezu7zNHLofErQOmxAur9Kzm X-Proofpoint-Spam-Reason: safe On 01/12/2025 9:57 am, Richard Fitzgerald wrote: > On 29/11/2025 2:28 pm, Krzysztof Kozlowski wrote: >> On 27/11/2025 16:58, Richard Fitzgerald wrote: >>> Use the __free(kfree) cleanup to replace instances of manually >>> calling kfree(). Also make some code path simplifications that this >>> allows. >>> >>> Signed-off-by: Richard Fitzgerald >>> --- >>>   sound/soc/codecs/cs-amp-lib.c | 29 ++++++++++++----------------- >>>   1 file changed, 12 insertions(+), 17 deletions(-) >>> >>> diff --git a/sound/soc/codecs/cs-amp-lib.c b/sound/soc/codecs/cs-amp- >>> lib.c >>> index d8f8b0259cd1..8c9fd9980a7d 100644 >>> --- a/sound/soc/codecs/cs-amp-lib.c >>> +++ b/sound/soc/codecs/cs-amp-lib.c >>> @@ -7,6 +7,7 @@ >>>   #include >>>   #include >>> +#include >>>   #include >>>   #include >>>   #include >>> @@ -309,9 +310,8 @@ static struct cirrus_amp_efi_data >>> *cs_amp_get_cal_efi_buffer(struct device *dev, >>>                                    efi_guid_t **guid, >>>                                    u32 *attr) >>>   { >>> -    struct cirrus_amp_efi_data *efi_data; >>> +    struct cirrus_amp_efi_data *efi_data __free(kfree) = NULL; >> >> This is an undesired syntax explicitly documented as one to avoid. You >> need here proper assignment, not NULL. Please don't use cleanup.h if you >> do not intend to follow it because it does not make the code simpler. >> > > LOL > The new system to improve cleanup introduces new cleanup bugs. :) > >> >> Best regards, >> Krzysztof > I found 119 other instances of this _free(kfree) something = NULL; idiom in sound/ and ~300 across the whole kernel. So you've got quite some code to fix.