Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Sen Wang <sen@ti.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
	<tiwai@suse.com>, <devarsht@ti.com>, <v-singh1@ti.com>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: fix graph_util_is_ports0() for DT overlays
Date: Sun, 8 Mar 2026 23:12:48 -0500	[thread overview]
Message-ID: <f339be72-7566-4dbb-b7fe-e681c6912ab2@ti.com> (raw)
In-Reply-To: <87jyvl25tf.wl-kuninori.morimoto.gx@renesas.com>

On 3/8/26 19:40, Kuninori Morimoto wrote:
> 
> Hi Sen
> 
>> But when the DPCM topology comes from a DT overlay, __of_attach_node()
>> inserts new children at the head of the sibling list, reversing the
>> order. of_get_child_by_name() then returns ports@N instead of ports@0,
>> causing all front-end links to be classified as back-ends in
>> audio-graph-card2. The card subsequently breaks and registers with no
>> PCM devices.
> (snip)
>> +       /* match "ports" or "ports@0" by unit address in node name */
> 
> Could you please indicate this method is needed for DT overlay ?
> It is the main reason.
> 
> Thank you for your help !!
> 
> Best regards
> ---
> Kuninori Morimoto

Thanks for the feedback Kuninori,

Will update the code comment and send a v2 shortly.

Best,
Sen Wang

      reply	other threads:[~2026-03-09  4:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08  4:41 [PATCH] ASoC: simple-card-utils: fix graph_util_is_ports0() for DT overlays Sen Wang
2026-03-09  0:40 ` Kuninori Morimoto
2026-03-09  4:12   ` Sen Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f339be72-7566-4dbb-b7fe-e681c6912ab2@ti.com \
    --to=sen@ti.com \
    --cc=broonie@kernel.org \
    --cc=devarsht@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=v-singh1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox