From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA8F3D668E for ; Mon, 20 Jul 2026 09:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540944; cv=none; b=aQynd7aeKEl7Vyl04Pr4RX/k9vedBDBmZGcaqE/TzVms5GLvydNQlUB1qCaTLmAZHZ4kIyWPIcWkU0Ag3adnGg4Bt5IY1cwtClklUclaG4013Se7k64R991Y+0o5BAERAGXtfSfP1D5PEleCHJd5cJadu4wDk2sprCc8VGXHEsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784540944; c=relaxed/simple; bh=v/SAH+AN3dxByhF5WKSM7Zc9mNjpaydjkLZ0z+gJdgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N2j9miAW3dTnzhyVupQbijuZNvPYv+M3wVA+o3tl+xmQJHnwwy7Vf202vEZJ3r6hgPsq8VQNOxMzZ9aHLmgLqzUTm9VHcyxT1DotDrEJSHMF2wOdwUFZFrWwjE2XldURqAUZaX3IPTeHI/UYVi6qz1o9yhulSRm/CUW1lDwsJZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fQ7/sXQa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BQ3pK3Gu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fQ7/sXQa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BQ3pK3Gu" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K9aUNn1723287 for ; Mon, 20 Jul 2026 09:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nFlgqptCwNUSrSbNkvccJlfiQ3eq+SyelinnTuxDIPE=; b=fQ7/sXQaDFGBvHJH 9NM1U+k6+Cv3M8vy0JiVM/rFbNrEKkXE322bXnQLBhyaf5JtXxkwoTqi/iKEFFXw LW1q9rumjNbz0ddDiY72zuoPbQoaApI067/hSgms90DU7yBCx3mIL9Bv9aX3ekil FRr+kXYtcObeB6ofq0u6U6WupiiZchnz9tFN6nkkxcjOL+ojBBDAwxDYoylo43T/ Tv8Ydyg73WwGFEth/+tpIZ8JX88N16WEpo6aJfdmnmsaIYaeRZuFNj9z3wpKAda/ xfmNIIp4bnmp+wRr6rFO6T9UTyCisJ0RwBWR4ulZrs+zF8DCC71eEoUjahXEa2yG GpHZrA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs505gv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 09:48:55 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc5faecf01so196247895ad.1 for ; Mon, 20 Jul 2026 02:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784540935; x=1785145735; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nFlgqptCwNUSrSbNkvccJlfiQ3eq+SyelinnTuxDIPE=; b=BQ3pK3GuWHRdO2B1pntAT9VpASCkrdQCnJ516OU0XkE6SjAq8Luixktxa5qSTFhXdj UgHJ6JJ68BVY5opUhP9jIXJOfzWfuOcOpcwCYe5rB3rplD3loSI+AtaEen3PSlt4C6iE F6B0fvTG3gwAT98UEeg/BUkgKJOcIEnV9+hbwbFo6Vff3Y3kIHEbWl7O0yMfic95Q63n J837zHs12pZgbKdtqzXcjuiT3zClrMKb710Tp/xQi12pjlsvRVTeaty+5df1fVyHkCPo 5f9ThGPJNiv4HvqVzfOccyJMk08QvUt6Hw6andD5srensk/DE5AmYQkWHCN5+TR5W0Yv q0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784540935; x=1785145735; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nFlgqptCwNUSrSbNkvccJlfiQ3eq+SyelinnTuxDIPE=; b=P9aW2U7hr4n46LuMoiDFQe7P9pXyemH/cI8oupBHiZpe+UOpVcF+sUP/sU2Mg8Zv5P z+FVc0j3ejDPfNJG6rGMzVrYydSpN987+fpuDMZwWsS2ecUQbg/k3ymRyB3M02a73k9+ jKZUNJHDELzt4E0f0lHDcDeW9OIIbbj2TNyDNS0rw25F4+mZCSkHCuXn3Yx61zv/2ycU f3KeLP/Re4v+oX5wypfWAGZOpTky75Z1Gh1qB0KMWddwT8oI7m9t5KC10qvrkjqTEB+w kF6CKRdzCAfBUe1/jfeA1LduS6Zdzu6dCwfzpDcAjgIuDmiM1tS3WYW7e41cAxcpn5BZ K75A== X-Forwarded-Encrypted: i=1; AHgh+Rpk3pIc7SbQBh5mz3M/qiGNXL4YXxyKRvv6mtoN3xYAYlEk91bUzNZTHb/ypNzb1qWrKUKD2q+jy8CJKw==@vger.kernel.org X-Gm-Message-State: AOJu0Ywh6gYtaKHtTkZJ+g5R1UpFDImpLR2iTp8YFrpIMFWVxGkjbdLW kM0MYpCHAnFJ9p4R4QANH/vVgu+RilXMJ73E8c7Jd8HwG+28YhZj0ZNqPoNK8InSi7z9g9QA3BP g1cqkduq6FFFC/ps5NDKvsw+0Xl2W4PXCyZqF3lXcM5hb+kbgjTC+MDwOMKINutc/eg== X-Gm-Gg: AfdE7ckavgyA+fA4QLsH8472zciPaOajUVqSgNKN6PP7JB1bgMZ+ILgJOq+pAYId1qO TYhG1FVc7UBnjAvaPv+ZKvAKxmKMla70g/GjmpXO7i5MZISwY4YySGI0noW2Wb5c7PWhkiHxYhr Pl8TGAPJmreNsioUR+nUgwGEzWcjs43ZppW7Jmo8z4Btb7vEfURQZCLELEfiraE8YIQy/bmi/KY OlrQ0kxxH1oseQft+QoI0he9qjL96epSwS699v4Jr5tzFcQs8zk3j7/ZjwuzTE7IgAnoAE2x8qR f5gZ5+b2fIUA83zRWNQLWV2zttx/Eroq5QKxnq//JNBxN3ovomnNLLYorO0x2WugJK9+sCcMUW8 06JmHEMglz2WDA3v+CINSfTyxrTwdBof9tC6F470= X-Received: by 2002:a17:903:3c4e:b0:2ca:ecfa:1308 with SMTP id d9443c01a7336-2cf3489a83cmr142978895ad.20.1784540935089; Mon, 20 Jul 2026 02:48:55 -0700 (PDT) X-Received: by 2002:a17:903:3c4e:b0:2ca:ecfa:1308 with SMTP id d9443c01a7336-2cf3489a83cmr142978595ad.20.1784540934620; Mon, 20 Jul 2026 02:48:54 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf345110besm54179945ad.36.2026.07.20.02.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 02:48:54 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 15:18:47 +0530 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260714145250.2473461-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260714145250.2473461-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260715-crafty-cheerful-goat-baba95@quoll> <5612a63b-4052-41af-8676-9d92811dee9d@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDEwOSBTYWx0ZWRfXx1rFNmeeehmR hvgUKP8CeRsdKykUy0XLNWF96mb+DW0u5i/rpYWa/R1Ar0zThyHHjUfRO1+Jd8apDMfRfZcRpUT 80irHt3BxjFVmaCQT074UYzH4IxF8wk= X-Proofpoint-GUID: ASS8rSbFf9nrKwBFr9vnExH3JUNbzzdl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDEwOSBTYWx0ZWRfX2kUgJbuoX8ng eSK+JJZuqBPYhQOS4aCOkwyPnwCquzHVdez49E2zTy3auInPLFcqG1xjlU7gQ+fObE2+zrY07Ek qPuiT5OcJIo/9fn+wk3Yh1n8pOTLlU1K9++DEEaPcp9PKYmQaM9ZAyz61oW0kEmc0Ci3mRx7l72 JuAMC/1IbDF4wngA5tcpJzx2emfHpbcpBMQzaI7lMzrm82YRkzDaSrjvHlSJblNYBbtba/rgj7l kXkvqqY8Z1zQtqbXUfC11DV7bld5dQZZnekTtxfwzJKEz+m9bxegCojOqQCXlj45E72zVRVjLfd PbbdYrswokgRLvj7P/mTyt4DpItyFq1b+9wGBQr9+bC2VoY2J33/YA2GrK4mJGQzu/RLM0E9GoD 6l4M38zfKSo87NtFjwz1P+8HGS8xshoW7ApggAzc34VdXBY5pN6ioTO5KztR3bRMMfZBMVIDk+a J/t0k6Jaa8CpfEWYhdw== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5def07 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=OGkrOE9Y-7fm8TEiaLcA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: ASS8rSbFf9nrKwBFr9vnExH3JUNbzzdl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_01,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200109 On 7/16/2026 11:49 AM, Krzysztof Kozlowski wrote: > On 15/07/2026 08:58, Mohammad Rafi Shaik wrote: >> >> >> On 7/15/2026 11:35 AM, Krzysztof Kozlowski wrote: >>> On Tue, Jul 14, 2026 at 08:22:48PM +0530, Mohammad Rafi Shaik wrote: >>>> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >>>> describe Digital Audio Interface (DAI) child nodes. >>>> >>>> Add #address-cells and #size-cells to allow representation of multiple >>>> DAI instances as child nodes, and define a dai@ pattern to document >>>> per-DAI properties such as the interface ID and associated clocks. >>>> >>>> On platforms such as Monaco and Lemans, third-party codecs are hardware >>>> wired to the SoC and do not always have an in-tree codec driver to manage >>>> their clocks. For these designs, clock line enablement must be driven >>>> from the platform side, and this series provides the necessary support >>>> for that. >>>> >>>> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >>>> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >>>> introduces the required device tree binding support to represent and >>>> vote for these clocks from the kernel. >>>> >>>> Co-developed-by: Srinivas Kandagatla >>>> Signed-off-by: Srinivas Kandagatla >>>> Signed-off-by: Mohammad Rafi Shaik >>>> --- >>>> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 89 +++++++++++++++++++ >>>> 1 file changed, 89 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> index 2fb95544d..b37c62ccd 100644 >>>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> @@ -21,6 +21,82 @@ properties: >>>> '#sound-dai-cells': >>>> const: 1 >>>> >>>> + '#address-cells': >>>> + const: 1 >>>> + >>>> + '#size-cells': >>>> + const: 0 >>>> + >>>> +# Digital Audio Interfaces >>>> +patternProperties: >>>> + '^dai@[0-9a-f]+$': >>>> + type: object >>>> + description: >>>> + Q6DSP Digital Audio Interfaces. >>>> + >>>> + properties: >>>> + reg: >>>> + maxItems: 1 >>>> + description: >>>> + Digital Audio Interface ID >>>> + >>>> + clocks: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + description: MI2S clocks (mclk, bclk and/or eclk). >>>> + >>>> + clock-names: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + >>>> + allOf: >>>> + - oneOf: >>>> + - properties: >>> >>> Please don't do such stuff. Did you find it somewhere? If yes, then >>> where - so we can remove it? >>> >> >> It was not copied from another binding. >> >> It was my attempt to model the valid clock combinations. >> >>> I gave you the close-to-exact syntax I expect. It was nothing like this. >> >> clocks: >> minItems: 1 >> maxItems: 3 >> >> >> clock-names: >> minItems: 1 >> maxItems: 3 >> items: >> enum: >> - mclk >> - bclk >> - eclk > > But I did not wrote anything like that. > >> >> The enum version does not enforce the positional relationship between >> clocks and clock-names, > > So you do not use my code, but something completely different and does > not work, therefore you come up with another approach. > > I don't know what to advise, but repeating myself seems pointless. > > Previous review stays valid. > Sorry about this patch. I attempted to address the AI and Sashiko review comments. will fall back to the suggested approach from the previous version. Thanks & regards, Rafi. > > >> >> which is why I tried the oneOf approach. >> >> My concern with the suggested syntax is that mclk is not mandatory for >> all platforms. >> >> For example, HAWI only requires bclk and does not use mclk, so requiring >> mclk as the first clock-name would reject valid DTs. > > Luckily I did not require mclk as first, so I do not understand why you > refer to something like that. > > > Best regards, > Krzysztof