Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: "Sheetal ." <sheetal@nvidia.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub
Date: Mon, 5 Jan 2026 16:06:22 +0000	[thread overview]
Message-ID: <f44287d4-2f76-409d-b537-038896c5bc59@nvidia.com> (raw)
In-Reply-To: <41cb1bac-5503-4765-b45a-200963448e5a@nvidia.com>

Hi Mark,

On 17/12/2025 13:40, Jon Hunter wrote:
> 
> On 17/12/2025 13:25, Sheetal . wrote:
>> From: sheetal <sheetal@nvidia.com>
>>
>> Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
>> in tegra210_ahub") attempted to fix the uninitialized flat cache warning
>> that is observed for the Tegra210 AHUB driver. However, the change broke
>> various audio tests because an -EBUSY error is returned when accessing
>> registers from cache before they are read from hardware. Revert this
>> change for now, until a proper fix is available.
>>
>> Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache 
>> warning in tegra210_ahub")
>> Signed-off-by: sheetal <sheetal@nvidia.com>
>> ---
>>   sound/soc/tegra/tegra210_ahub.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/ 
>> tegra210_ahub.c
>> index 261d9067d27b..e795907a3963 100644
>> --- a/sound/soc/tegra/tegra210_ahub.c
>> +++ b/sound/soc/tegra/tegra210_ahub.c
>> @@ -2077,7 +2077,7 @@ static const struct regmap_config 
>> tegra210_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA210_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra186_ahub_regmap_config = {
>> @@ -2085,7 +2085,7 @@ static const struct regmap_config 
>> tegra186_ahub_regmap_config = {
>>       .val_bits        = 32,
>>       .reg_stride        = 4,
>>       .max_register        = TEGRA186_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct regmap_config tegra264_ahub_regmap_config = {
>> @@ -2094,7 +2094,7 @@ static const struct regmap_config 
>> tegra264_ahub_regmap_config = {
>>       .reg_stride        = 4,
>>       .writeable_reg        = tegra264_ahub_wr_reg,
>>       .max_register        = TEGRA264_MAX_REGISTER_ADDR,
>> -    .cache_type        = REGCACHE_FLAT_S,
>> +    .cache_type        = REGCACHE_FLAT,
>>   };
>>   static const struct tegra_ahub_soc_data soc_data_tegra210 = {
> 
> 
> Acked-by: Jon Hunter <jonathanh@nvidia.com>

Now we are into the new year, I just wanted to send a reminder for this 
fix. We need to get this revert into v6.19.

Thanks!
Jon

-- 
nvpublic


  reply	other threads:[~2026-01-05 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 13:25 [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub Sheetal .
2025-12-17 13:40 ` Jon Hunter
2026-01-05 16:06   ` Jon Hunter [this message]
2026-01-05 16:47     ` Mark Brown
2026-01-13 11:54 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f44287d4-2f76-409d-b537-038896c5bc59@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sheetal@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox