From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8713631B131; Thu, 11 Sep 2025 13:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757597986; cv=pass; b=BS/UwxN/rGv4iy/M9bK7PaIC+VXoISyihRUyYNIUeU3XY3bDcvICS57/gq5TYmE23mdkdWDpQ8U4tCx2BDslFwlZ7RRFkB6P16r/IuJs2EI8CHFLLZjt5mrx8AD34mMovq5q/AA6Dl0FTDCSJIPrx25ZRq5FtyXGk3tudr3sECw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757597986; c=relaxed/simple; bh=j8lpntQzzYMtk7wMPyC9pfzz7cSxvnQauwFcEWCrz+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJHudjNn0ZVehifHiMEOA6R8YFRlzvXYTLFvtuiNy1cFHz061kS4Piu6WXFgy3vBMkyBMVE/+RjUwy5q0KmmIzvb2e9aSPvWgs7y3MMkZb9RljlbHp/52ruMX1Zck2RWcPrB3zA+aAkvh/XNF+x4VNidmJpnVk99QD5iy9Zvrn8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=Fk3d5f5c; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="Fk3d5f5c" ARC-Seal: i=1; a=rsa-sha256; t=1757597924; cv=none; d=zohomail.com; s=zohoarc; b=cW8WQVw54kCwOrp4Z6nOM5zB+0ttwfZp2WlQWstN3VR5HDOvUIUqj7OMd52M9joD6VV4KN+dfh1dQl0/5irEs3WahGrue0xzDie3hjaV5tdBCW5k0AttByOZuRIZk3wFOzjsTr7EerdMeKTQT6Q0jEdxIQCRmWwkyus6WmtY4rc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757597924; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=z0wfAw1RoyH3XxGnHu3OjGHYgzFrel7esRCkMh235Uo=; b=OeyfDXnfBQFt2RGO4gMm6yb7HyyWhJFSbXpukrZivXBHUSu4zZB8tX0p+rGZvOotIcQlOG+e+z+/2AUnulQ/1bXPqaS4dqL3N5WfURJHVehrqpu51EIbJ/iUuIEJYOINb4anVnFgKEZp2BKvmfJNvG1rj5/t+jyUxszFxqMpZ4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1757597924; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=z0wfAw1RoyH3XxGnHu3OjGHYgzFrel7esRCkMh235Uo=; b=Fk3d5f5c7xQh1L26LGxVS1MYZeolPRgvuj4odZIpMebZ02Z5jpCxFefRidPAF1ey NwGxrrIocLa0JWk6u1Dpzl1zGCrU4lt1loeAoSLF2sMV/6OmrnCFottPBZbgLe1Y1W+ P4w+y0nD1DpQDK/sWlie56qNQMIlY8RyUyzFaKLM= Received: by mx.zohomail.com with SMTPS id 175759792104776.9989768199938; Thu, 11 Sep 2025 06:38:41 -0700 (PDT) Message-ID: Date: Thu, 11 Sep 2025 10:38:23 -0300 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML To: Krzysztof Kozlowski Cc: airlied@gmail.com, amergnat@baylibre.com, andrew+netdev@lunn.ch, andrew-ct.chen@mediatek.com, angelogioacchino.delregno@collabora.com, broonie@kernel.org, chunkuang.hu@kernel.org, ck.hu@mediatek.com, conor+dt@kernel.org, davem@davemloft.net, dmitry.torokhov@gmail.com, edumazet@google.com, flora.fu@mediatek.com, houlong.wei@mediatek.com, jeesw@melfas.com, jmassot@collabora.com, kernel@collabora.com, krzk+dt@kernel.org, kuba@kernel.org, kyrie.wu@mediatek.corp-partner.google.com, lgirdwood@gmail.com, linus.walleij@linaro.org, louisalexis.eyraud@collabora.com, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mchehab@kernel.org, minghsiu.tsai@mediatek.com, mripard@kernel.org, p.zabel@pengutronix.de, pabeni@redhat.com, robh@kernel.org, sean.wang@kernel.org, simona@ffwll.ch, support.opensource@diasemi.com, tiffany.lin@mediatek.com, tzimmermann@suse.de, yunfei.dong@mediatek.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org, netdev@vger.kernel.org References: <20250820171302.324142-1-ariel.dalessandro@collabora.com> <20250820171302.324142-2-ariel.dalessandro@collabora.com> <20250821-silky-slug-of-novelty-e4bb64@kuoka> <5421cfe7-dfe0-4bb8-8722-6f449cd365be@kernel.org> Content-Language: en-US From: Ariel D'Alessandro In-Reply-To: <5421cfe7-dfe0-4bb8-8722-6f449cd365be@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Krzysztof, On 9/9/25 3:32 AM, Krzysztof Kozlowski wrote: > On 08/09/2025 19:52, Ariel D'Alessandro wrote: >> Krzysztof, >> >> On 8/21/25 3:46 AM, Krzysztof Kozlowski wrote: >>> On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote: [...] >>>> + - enum: >>>> + - mediatek,mt8173-mdp-rdma >>>> + - mediatek,mt8173-mdp-rsz >>>> + - mediatek,mt8173-mdp-wdma >>>> + - mediatek,mt8173-mdp-wrot >>>> + - items: >>>> + - enum: >>>> + - mediatek,mt8173-mdp-rdma >>>> + - mediatek,mt8173-mdp-rsz >>>> + - mediatek,mt8173-mdp-wdma >>>> + - mediatek,mt8173-mdp-wrot >>>> + - const: mediatek,mt8173-mdp >>> >>> This makes no sense. How devices can be compatible and can not be >>> compatible. >> >> According to the driver source code (and the previous txt mt8173-mdp >> bindings), there must be a "controller node" with compatible >> `mediatek,mt8173-mdp`. Then its sibling nodes (including itself) should > > But you did not define "mediatek,mt8173-mdp" here, so what are you > talking about? > > I talk here about "wrot" and others, I thought it is obvious from the > mistake in the schema. Ack. [...] >>>> + >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + const: mediatek,mt8173-mdp >>> >>> This makes no sense either. >> >> Same question above about compatibles. > > How same question? Do you understand this code? It is nothing the same - > you have here contains! Ack. Will resubmit properly in v2. Thanks, -- Ariel D'Alessandro Software Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718