From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Handrigan <paulha@opensource.cirrus.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: cs530x: Support for cs530x ADCs
Date: Fri, 14 Jun 2024 10:17:56 +0200 [thread overview]
Message-ID: <f7d1aa9e-c023-4c54-acfb-566d3b4b6fe9@kernel.org> (raw)
In-Reply-To: <ZmsyhKiuRI1Dg8l4@ediswmail9.ad.cirrus.com>
On 13/06/2024 19:55, Paul Handrigan wrote:
> On Mon, Jun 10, 2024 at 10:46:26AM +0200, Krzysztof Kozlowski wrote:
>
>>> +
>>> + if (cs530x->reset_gpio) {
>>> + usleep_range(2000, 2100);
>>> + gpiod_set_value_cansleep(cs530x->reset_gpio, 1);
>>
>> 1 is to keep device in reset? This looks like you are using logical
>> values inverted.
> Thanks. The reset pin is active low. I will also change the dt binding
> example to reflect that.
The value here is logical from driver point of view, not wire level, so
you use wrong code.
If you tested it with real and correct DTS, you would see it does not work.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-14 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 20:27 [PATCH 0/2] Cirrus Logic family of ADCs Paul Handrigan
2024-06-07 20:27 ` [PATCH 1/2] ASoC: dt-bindings: cirrus,cs530x: Add initial DT binding Paul Handrigan
2024-06-10 8:48 ` Krzysztof Kozlowski
2024-06-07 20:27 ` [PATCH 2/2] ASoC: cs530x: Support for cs530x ADCs Paul Handrigan
2024-06-09 9:34 ` kernel test robot
2024-06-10 8:46 ` Krzysztof Kozlowski
2024-06-13 17:55 ` Paul Handrigan
2024-06-14 8:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d1aa9e-c023-4c54-acfb-566d3b4b6fe9@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=paulha@opensource.cirrus.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox