From: Srinivas Kandagatla <srini@kernel.org>
To: Kumar Anurag <kumar.singh@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v1 3/4] ASoC: qcom: q6dsp: Update bit format support for secondary i2s
Date: Tue, 14 Apr 2026 14:21:37 +0000 [thread overview]
Message-ID: <f9806784-8145-407e-b77b-403327aaccf1@kernel.org> (raw)
In-Reply-To: <20260413091937.134469-4-kumar.singh@oss.qualcomm.com>
On 4/13/26 9:19 AM, Kumar Anurag wrote:
> Add 32bit for playback and capture over secondary mi2s.
>
> Signed-off-by: Kumar Anurag <kumar.singh@oss.qualcomm.com>
> ---
Pretty much simillar changes a are already submitted by " [PATCH v1 0/2]
ASoC: qcom: q6dsp-lpass-ports: Add support for extended sampling rates
and PCM formats" https://lkml.org/lkml/2025/11/18/673
--srini
> sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> index 4eed54b071a5..0664f18d7a44 100644
> --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
> @@ -380,7 +380,9 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
> .stream_name = "Secondary MI2S Playback",
> .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
> SNDRV_PCM_RATE_16000,
> - .formats = SNDRV_PCM_FMTBIT_S16_LE,
> + .formats = SNDRV_PCM_FMTBIT_S16_LE |
> + SNDRV_PCM_FMTBIT_S24_LE |
> + SNDRV_PCM_FMTBIT_S32_LE,
> .channels_min = 1,
> .channels_max = 8,
> .rate_min = 8000,
> @@ -394,7 +396,8 @@ static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
> .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
> SNDRV_PCM_RATE_16000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE |
> - SNDRV_PCM_FMTBIT_S24_LE,
> + SNDRV_PCM_FMTBIT_S24_LE |
> + SNDRV_PCM_FMTBIT_S32_LE,
> .channels_min = 1,
> .channels_max = 8,
> .rate_min = 8000,
next prev parent reply other threads:[~2026-04-14 14:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 9:19 [PATCH v1 0/4] Enable audio over HDMI and Kumar Anurag
2026-04-13 9:19 ` [PATCH v1 1/4] arm64: dts: qcom: Enable secondary mi2s Kumar Anurag
2026-04-14 11:58 ` Konrad Dybcio
2026-04-14 14:56 ` Dmitry Baryshkov
2026-04-13 9:19 ` [PATCH v1 2/4] arm64: dts: qcom: qcs6490: Enable DP audio Kumar Anurag
2026-04-14 9:28 ` Konrad Dybcio
2026-04-14 14:58 ` Dmitry Baryshkov
2026-04-13 9:19 ` [PATCH v1 3/4] ASoC: qcom: q6dsp: Update bit format support for secondary i2s Kumar Anurag
2026-04-14 9:54 ` Konrad Dybcio
2026-04-14 11:38 ` Mark Brown
2026-04-14 14:21 ` Srinivas Kandagatla [this message]
2026-04-13 9:19 ` [PATCH v1 4/4] ASoC: qcom: sc8280xp: don't force S16_LE in hw_params fixup Kumar Anurag
2026-04-14 11:40 ` Mark Brown
2026-04-15 11:06 ` Alexey Klimov
2026-04-14 14:54 ` [PATCH v1 0/4] Enable audio over HDMI and Dmitry Baryshkov
2026-04-14 14:58 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9806784-8145-407e-b77b-403327aaccf1@kernel.org \
--to=srini@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kumar.singh@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox