From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A3822156A for ; Fri, 7 Nov 2025 04:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762490096; cv=none; b=Si73GmZCpak+q4H1/HTfcE/yoNAK881IgyvjRpNM6Jx6s2EXDNITYXgbdGa0QoHg/fsEk4Xz3fpLCw83SqTNKh7q7xe3qrFCr52cYA/rrc88s1UrwVq+YkN4RTPfHKOjakQFoiEBGjzpGzS1b7+XxhgkiLYMTob+cfpyO3uE/VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762490096; c=relaxed/simple; bh=j2VybcDqep5GTm5XHWYR/F0on0LqEt84R5Ole3I+g0A=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=nyTpIXaNNST2+MfylIlqgJWZzEWwU3Hro7kchCa6hiZROCw9r3EPNuU8t2ANIA985UbmXRvw7thJxcIqJfdRLnxA5n+9UBZWeeuCoozMLo6J+HXdzp1XrKatVzpXdvyXGI2Ge3OIDofzuC6qDrcvVMvPmh+Ltjl/C2HTwutDXCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Avjy4ZVy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Avjy4ZVy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47754547a38so2482675e9.2 for ; Thu, 06 Nov 2025 20:34:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762490093; x=1763094893; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:from:to:cc:subject:date:message-id:reply-to; bh=wsQ8+DdBhXQQJacebUZgMqys6BflOEfAmdOYN7onnYI=; b=Avjy4ZVybMkm08TV6HiiJQuCQorPDPKWul/SeTTf3Ix0jjNRVxh4XD2Ai6B9/qRaWb 1+W7bBpw8wCpGMpYv8X1B2TDFUnMJW1dOzR9YM0PIrjb/L9x9TqAmsvkYPI/QUpuMDyH oKFPAQyj1HWCFP78qSxQr3WJ85hYaTTYaHnvhAUWkJ+z6EI6qt8KgfYerz98imKxkn81 vx8j4lyk4lYiS+qmhegvJv7mpSShhv45DwKzKUP9khUGrrB6SjpHCCyUDKigqIy1EMZT s/8TJHX8x5qcKbUpGi+1LVlqx3wtW6QJ3BOGmk9UWSfRYHzYIwaPlNwYFsyYP58TkSqx IICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762490093; x=1763094893; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wsQ8+DdBhXQQJacebUZgMqys6BflOEfAmdOYN7onnYI=; b=JnSmsv0nBl6j7mCeBPueVFUCu2qio8QVP+SetZOSFrte+2Lxf5BKrF8aZgb0OsCwQx lg2c0PVpGFEcuYcQXOkKlWn3tRHNT/GPFN++9n0bBe5YKI592gV19DkapCBZkQYQMZkF yBdfNLnJvaVPZ3hgt10U7ukmWlYGeACI9fAeyvKMIMf4+P/zB2p1YfGtZErLkzDt63+n vNOOkn/JwygotW851HFOrYFB1QnCcGiVqI4mHiox/P/I70gvkcIg+z+tyeQmjdnpMNMv 6eOvyhI6F2ytjDGzxZCFKv8pKmhtXY+UC/EOoidt65k7a6Zo3dRrfmUBELlU0oZ3HGog YuIg== X-Forwarded-Encrypted: i=1; AJvYcCWV3MlzuFvMTVg9MGGgh0bh2+xkuDjIEWOEWtMK5lNLiZ9QeSmuTAZWzAG9H6N7PUknMaacjSAYe7Pl1A==@vger.kernel.org X-Gm-Message-State: AOJu0YxqCtDh9rBaIWaRKaAPBib9lCOSJ1ZH7iqUYBP3IrMIVrGHw2u/ QB8aPUyvGbTJVVyLg+JbxGF8RW64kiuBd9ec7qQN4RqVvU5oNNmTQ9/K X-Gm-Gg: ASbGncueWS/aSSnVeDuOBwbS3mHffZWeyvOnwa33ktqNh2vBKTxwdij9A45bwM1+65n EiHquKBoukUKseFa6YcRnfAOlr/TY2WVo5Rw7cxP3pXHhSl1nf45wW3oF3JtdeuVMWE50lBzNys GfP3iv0zs9EtUcl7ww03b1rjz+m0AhJTwWeFIbizGIgkPSLs6VOmXQqlF+5kJ3kzPsWWQbY3M07 yAMlEUQeloDxGcpCjzwi9Zp7hxx65vrbK/r9fnRK07G6mNTuTVUD/4P0t7X7O1HXkUsbIjuALgR qseI08lzrrS7gQYDBZdmd/5KA2IB517aEtWbeIlC5CTLarg3Cgkx6hPPMn7rRqBibZDIWGcdUO+ o3hCvspfMJ0xBHDgW09bcGAZO2NuVxRJpq5MHX4H7ixiX6+C5ubA+ahyTebtuXgCXfO70szDQaJ 60nA2PbAeoB5BYCg== X-Google-Smtp-Source: AGHT+IH8iYOa3zkzdeQ81462RWXFWW0SZmtk+MjUb5V+E2Hp+U6gTm6QWNnh28oZTtNNxpK5jLmI4A== X-Received: by 2002:a05:600c:354b:b0:477:a58:2d6b with SMTP id 5b1f17b1804b1-4776bc8a01emr9870455e9.7.1762490092703; Thu, 06 Nov 2025 20:34:52 -0800 (PST) Received: from [172.23.94.183] ([147.161.143.88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4776bcfcfc7sm29496635e9.12.2025.11.06.20.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 20:34:52 -0800 (PST) From: HariKrishna Sagala X-Google-Original-From: HariKrishna Sagala Date: Fri, 7 Nov 2025 10:04:13 +0530 (IST) To: Shuah Khan , hariconscious@gmail.com, shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com cc: khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl: fsl_ssi: Replace deprecated strcpy() with strscpy() In-Reply-To: <0c7f307c-9de5-4d67-b9da-e728d43e00b6@linuxfoundation.org> Message-ID: References: <20251105052113.39999-3-hariconscious@gmail.com> <0c7f307c-9de5-4d67-b9da-e728d43e00b6@linuxfoundation.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 6 Nov 2025, Shuah Khan wrote: > On 11/4/25 22:21, hariconscious@gmail.com wrote: > > From: HariKrishna Sagala > > > > strcpy() is deprecated,use strscpy() instead. > > No functional changes intended. > > Link: https://github.com/KSPP/linux/issues/88 > > > > Signed-off-by: HariKrishna Sagala > > --- > > This patch replaces strcpy() call with the strscpy() API. > > strscpy() is preferred over strcpy()/strncpy() as per the > > kernel documentation. > > Which kernel documentation and can you add why strscpy() ie > better than strcpy() instead saying "as per the kernel documentation." > > > > Thank you. > > > > sound/soc/fsl/fsl_ssi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c > > index 320108bebf30..b2e1da1781ae 100644 > > --- a/sound/soc/fsl/fsl_ssi.c > > +++ b/sound/soc/fsl/fsl_ssi.c > > @@ -1447,7 +1447,7 @@ static int fsl_ssi_probe_from_dt(struct fsl_ssi *ssi) > > dev_err(dev, "failed to get SSI index property\n"); > > return -EINVAL; > > } > > - strcpy(ssi->card_name, "ac97-codec"); > > + strscpy(ssi->card_name, "ac97-codec"); > > } else if (!of_property_read_bool(np, "fsl,ssi-asynchronous")) { > > /* > > * In synchronous mode, STCK and STFS ports are used by RX > > > > base-commit: 284922f4c563aa3a8558a00f2a05722133237fe8 > > thanks, > -- Shuah > Please find the below reference links. https://github.com/KSPP/linux/issues/88 https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy Thank you.