From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: phucduc.bui@gmail.com,
Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
povik+lin@cutebit.org, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Andrei Simion <andrei.simion@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: Kees Cook <kees@kernel.org>,
Syed Saba Kareem <syed.sabakareem@amd.com>,
wangdicheng <wangdicheng@kylinos.cn>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Neo Chang <YLCHANG2@nuvoton.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
u.kleine-koenig@baylibre.com, Pengpeng Hou <pengpeng@iscas.ac.cn>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Hemanth Selam <hemanth.selam@gmail.com>,
Md Shofiqul Islam <shofiqtest@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Zain Aboobacker <zainaboobacker33@gmail.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
Bo Shen <voice.shen@atmel.com>, Vinod Koul <vkoul@kernel.org>,
linux-sound@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org,
imx@lists.linux.dev, linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/24] ASoC: Fix constraint return value handling
Date: Tue, 13 Oct 2026 11:43:54 +0530 [thread overview]
Message-ID: <fc30ea4e-3c2f-4ba4-9ae2-054db9b49fd5@amd.com> (raw)
In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com>
On 10/8/26 16:08, phucduc.bui@gmail.com wrote:
> [You don't often get email from phucduc.bui@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Hi all,
>
> snd_pcm_hw_constraint_minmax() and snd_pcm_hw_constraint_integer()
> may return positive values on success. However, ASoC only marks the
> DAI, link, or component as started or opened when the corresponding
> callback returns 0.
>
> This series fixes affected ASoC drivers to return 0 on success and
> properly handle rollback paths.
>
> Found by manual code inspection.
For AMD patches:
Reviewed-By: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>
> Compile-tested only.
>
> Best regards,
> Phuc
>
> bui duc phuc (24):
> ASoC: amd: acp: Fix .close() being skipped on rollback
> ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback
> ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollback
> ASoC: amd: raven: Fix acp3x_dma_close() being skipped on rollback
> ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback
> ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback
> ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback
> ASoC: apple: mca: Ensure the DAI is marked as started on success
> ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on
> rollback
> ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success
> ASoC: codecs: nau8325: Ensure the DAI is marked as started on success
> ASoC: codecs: nau8540: Ensure the DAI is marked as started on success
> ASoC: codecs: nau8821: Ensure the DAI is marked as started on success
> ASoC: codecs: nau8824: Ensure the DAI is marked as started on success
> ASoC: codecs: nau8825: Ensure the DAI is marked as started on success
> ASoC: codecs: wm8580: Ensure the DAI is marked as started on success
> ASoC: codecs: wm8782: Ensure the DAI is marked as started on success
> ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on
> rollback
> ASoC: intel: atom: Fix .shutdown() being skipped on rollback
> ASoC: renesas: fsi: Ensure the component is marked as opened on
> success
> ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback
> ASoC: renesas: rz-ssi: Ensure the component is marked as opened on
> success
> ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success
> ASoC: rockchip: rockchip_max98090: Mark the link as started on success
>
> sound/soc/amd/acp/acp-platform.c | 2 +-
> sound/soc/amd/ps/ps-pdm-dma.c | 2 +-
> sound/soc/amd/ps/ps-sdw-dma.c | 2 +-
> sound/soc/amd/raven/acp3x-pcm-dma.c | 2 +-
> sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 +-
> sound/soc/amd/vangogh/acp5x-pcm-dma.c | 2 +-
> sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +-
> sound/soc/apple/mca.c | 11 ++++++++---
> sound/soc/atmel/atmel-pcm-pdc.c | 2 ++
> sound/soc/codecs/cs42l42.c | 11 ++++++++---
> sound/soc/codecs/nau8325.c | 11 ++++++++---
> sound/soc/codecs/nau8540.c | 11 ++++++++---
> sound/soc/codecs/nau8821.c | 11 ++++++++---
> sound/soc/codecs/nau8824.c | 11 ++++++++---
> sound/soc/codecs/nau8825.c | 11 ++++++++---
> sound/soc/codecs/wm8580.c | 10 ++++++++--
> sound/soc/codecs/wm8782.c | 7 ++++++-
> sound/soc/fsl/imx-pcm-rpmsg.c | 2 +-
> sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +-
> sound/soc/renesas/fsi.c | 6 ++++--
> sound/soc/renesas/rcar/msiof.c | 6 ++++--
> sound/soc/renesas/rz-ssi.c | 18 +++++++++++++++---
> sound/soc/rockchip/rk3399_gru_sound.c | 9 +++++++--
> sound/soc/rockchip/rockchip_max98090.c | 10 ++++++++--
> 24 files changed, 119 insertions(+), 44 deletions(-)
>
> --
> 2.43.0
next prev parent reply other threads:[~2026-10-13 6:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:38 [PATCH 00/24] ASoC: Fix constraint return value handling phucduc.bui
2026-10-08 10:38 ` [PATCH 01/24] ASoC: amd: acp: Fix .close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` [PATCH 02/24] ASoC: amd: ps: Fix acp63_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 03/24] ASoC: amd: ps: Fix acp63_sdw_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 04/24] ASoC: amd: raven: Fix acp3x_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 05/24] ASoC: amd: renoir: Fix acp_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 06/24] ASoC: amd: vangogh: Fix acp5x_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 07/24] ASoC: amd: yc: Fix acp6x_pdm_dma_close() " phucduc.bui
2026-10-08 10:38 ` [PATCH 08/24] ASoC: apple: mca: Ensure the DAI is marked as started on success phucduc.bui
2026-10-08 10:38 ` [PATCH 09/24] ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on rollback phucduc.bui
2026-10-08 10:38 ` [PATCH 10/24] ASoC: codecs: cs42l42: Ensure the DAI is marked as started on success phucduc.bui
2026-10-08 10:47 ` Richard Fitzgerald
2026-10-08 11:00 ` Bui Duc Phuc
2026-10-08 10:38 ` [PATCH 11/24] ASoC: codecs: nau8325: " phucduc.bui
2026-10-08 10:38 ` [PATCH 12/24] ASoC: codecs: nau8540: " phucduc.bui
2026-10-08 10:38 ` [PATCH 13/24] ASoC: codecs: nau8821: " phucduc.bui
2026-10-08 10:38 ` [PATCH 14/24] ASoC: codecs: nau8824: " phucduc.bui
2026-10-08 10:38 ` [PATCH 15/24] ASoC: codecs: nau8825: " phucduc.bui
2026-10-08 10:38 ` [PATCH 16/24] ASoC: codecs: wm8580: " phucduc.bui
2026-10-08 10:38 ` [PATCH 17/24] ASoC: codecs: wm8782: " phucduc.bui
2026-10-08 10:38 ` [PATCH 18/24] ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on rollback phucduc.bui
2026-10-13 6:04 ` Chancel Liu
2026-10-14 11:42 ` Bui Duc Phuc
2026-10-08 10:38 ` [PATCH 19/24] ASoC: intel: atom: Fix .shutdown() " phucduc.bui
2026-10-08 10:38 ` [PATCH 20/24] ASoC: renesas: fsi: Ensure the component is marked as opened on success phucduc.bui
2026-10-08 10:38 ` [PATCH 21/24] ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback phucduc.bui
2026-10-13 0:02 ` Kuninori Morimoto
2026-10-13 4:18 ` Bui Duc Phuc
2026-10-13 5:49 ` Kuninori Morimoto
2026-10-13 10:12 ` Bui Duc Phuc
2026-10-13 23:38 ` Kuninori Morimoto
2026-10-14 15:22 ` claudiu beznea
2026-10-08 10:38 ` [PATCH 22/24] ASoC: renesas: rz-ssi: Ensure the component is marked as opened on success phucduc.bui
2026-10-08 10:38 ` [PATCH 23/24] ASoC: rockchip: rk3399_gru_sound: Mark the link as started " phucduc.bui
2026-10-08 10:38 ` [PATCH 24/24] ASoC: rockchip: rockchip_max98090: " phucduc.bui
2026-10-13 6:13 ` Mukunda,Vijendar [this message]
2026-10-14 11:39 ` [PATCH 00/24] ASoC: Fix constraint return value handling Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc30ea4e-3c2f-4ba4-9ae2-054db9b49fd5@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Frank.Li@nxp.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=Xiubo.Lee@gmail.com \
--cc=YLCHANG2@nuvoton.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=asahi@lists.linux.dev \
--cc=bhelgaas@google.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=chris.bainbridge@gmail.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=cristian.ciocaltea@collabora.com \
--cc=david.rhodes@cirrus.com \
--cc=ekffu200098@gmail.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=hemanth.selam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kai.vehmanen@linux.intel.com \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=magnus.damm@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=nicoleotsuka@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pengpeng@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=povik+lin@cutebit.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=shengjiu.wang@gmail.com \
--cc=shofiqtest@gmail.com \
--cc=syed.sabakareem@amd.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vkoul@kernel.org \
--cc=voice.shen@atmel.com \
--cc=wangdicheng@kylinos.cn \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zainaboobacker33@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox