From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D628B67A; Wed, 28 Aug 2024 08:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724832704; cv=none; b=WCpt5L3aFBP7a3OJL9opnXican6f6vr8L2oAZpjiywhCPb26YM25EelLqZOFIM/kYkeUhXxXP9EJazF+MBsBDyON68A2T3cfeTjwSQnoVHFNtWVY9Q5QBDEdeypqEjhQ71y1Bq7dNCXb1MntIJdY+f/qeMTelbGC0ABULfsBtwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724832704; c=relaxed/simple; bh=z5ax1ZalWXidUDedJCgVDkVZ65FRtsJfQ8bWiQvRpEM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b0zAsRsJCJu1E0zYJimXkYPNqu5eiSXVXUD8O1+TS4Z+N+zLMhX421GXFOsHcaOvMCutj4Xm3HxOU2h5ZzuuDxzOqr/n/vV3oj8DTRvor+VYFUKIGfJ+/klUHDQExBZzENw0DKBl4snAcSp8tNwQVJLnTKbAeppBiUEzSEgwCR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LPcp/4De; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LPcp/4De" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2DB4C4AF11; Wed, 28 Aug 2024 08:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724832704; bh=z5ax1ZalWXidUDedJCgVDkVZ65FRtsJfQ8bWiQvRpEM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LPcp/4DeFrt510Br0R0+k6EWaO7qQKhoNpHrOGqooxpH1KxGjxt/UkLQ4YqaWZIdp TCOBBUljuC1GPVFeUfSiofymDl7RlJQCID9Z+dBsOSGDt+AG8oMdXl80yPXFU77Aa0 3GCpLh6BYNK32ImiL0jqRtvJowPUaYsxpxOLC05YwvLazsAurkh5azE26k8FaaTxIa REAXZq8YZSCBBn2OiGewhfRe32FaxhWdyaOwPBssQXwkafJyRqSMVy6H3beVRKD0CH HDc5kyl0Nxj0L9mrsVJW4UCChvmQa4bWpvkXnBHPl/Iu0c/UkzO7iAEzu0NM2I5eLB dE6QC1m3RtVXQ== Message-ID: Date: Wed, 28 Aug 2024 10:11:40 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: dt-bindings: Add dt bindings definition file for imx28 saif To: Lukasz Majewski Cc: Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Fabio Estevam , Conor Dooley , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240827180528.2315563-1-lukma@denx.de> <20240828100111.10852309@wsk> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240828100111.10852309@wsk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/08/2024 10:01, Lukasz Majewski wrote: >>> +properties: >>> + compatible: >>> + const: fsl,imx28-saif >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + "#sound-dai-cells": >>> + const: 0 >>> + >>> + assigned-clock-parents: true >>> + assigned-clock-rates: true >>> + assigned-clocks: true >> >> These three should be dropped, redundant. > > Last two are present in definition of saif[01] in imx28.dtsi - so IMHO > it shall be added. But they are already accepted. Why they need to be mentioned twice? > > Moreover, those are present in fsl,sg5000.yaml dt-schema description. > There is no such file. >> >>> + >>> +unevaluatedProperties: false >>> + >>> +examples: >>> + - | >>> + saif0: saif@80042000 { >>> + #sound-dai-cells = <0>; >>> + compatible = "fsl,imx28-saif"; >>> + reg = <0x80042000 2000>; >>> + interrupts = <59>; >>> + clocks = <&clks 53>; >>> + dmas = <&dma_apbx 4>; >>> + dma-names = "rx-tx"; >>> + }; >>> + - | >>> + saif1: saif@80046000 { >> >> Just one example, could be this one as more complete. > > This is important, as saif1 has "fsl,saif-master" which allows to have > full duplex PCM communication (by default on imx28 single saif is > half-duplex). > So keep saif1. Best regards, Krzysztof