Re: [PATCH v3 00/13] Add SDCA class driver

[Maciej Strozek <mstrozek@opensource.cirrus.com>]

W dniu czw, 06.11.2025 o godzinie 11∶44 +0000, użytkownik Charles
Keepax napisał:
> This series adds an initial SDCA class driver, this consists of a
> primary driver attached to the SoundWire device, and auxiliary
> drivers
> representing each of the functions of the SDCA device. These drivers
> all
> use the APIs added over the past series's to provide the class
> functionality, as such these final drivers themselves are quite thin.
> 
> Also a few fix ups at the start of the series that have gathered up
> whilst the last SDCA series was in review.
> 
> Thanks,
> Charles
> 
> Changes since v2:
>  - Updated the locking in sdca_fdl_process
>  - Correct some spelling in comments
>  - Renamed suspend/resume functions to be a little short
> 
> Changes since v1:
>  - Add a bunch of bug fix patches
>  - Change some prints to dbgs
>  - Add some additional comments
>  - Flip order on regcache operations in resume
> 
> 
> Charles Keepax (12):
>   ASoC: SDCA: Remove duplicated module macros
>   ASoC: SDCA: Fix missing dash in HIDE DisCo property
>   ASoC: SDCA: Add missing forward declaration in header
>   ASoC: SDCA: Correct FDL locking in sdca_fdl_process()
>   ASoC: SDCA: Add comment for function reset polling
>   ASoC: SDCA: Move most of the messages from info to debug
>   ASoC: SDCA: Use helper macros for control identification
>   ASoC: SDCA: Factor out helper to process Control defaults
>   ASoC: SDCA: Populate regmap cache for readable Controls
>   ASoC: SDCA: Add helper to write initialization writes
>   ASoC: SDCA: Add basic SDCA class driver
>   ASoC: SDCA: Add basic SDCA function driver
> 
> Pierre-Louis Bossart (1):
>   ASoC: SDCA: add function devices
> 
>  include/linux/soundwire/sdw_registers.h |   2 +
>  include/sound/sdca.h                    |  14 +
>  include/sound/sdca_regmap.h             |   2 +
>  sound/soc/sdca/Kconfig                  |  18 +
>  sound/soc/sdca/Makefile                 |  10 +-
>  sound/soc/sdca/sdca_class.c             | 304 ++++++++++++++++
>  sound/soc/sdca/sdca_class.h             |  37 ++
>  sound/soc/sdca/sdca_class_function.c    | 460
> ++++++++++++++++++++++++
>  sound/soc/sdca/sdca_fdl.c               |   8 +-
>  sound/soc/sdca/sdca_function_device.c   | 117 ++++++
>  sound/soc/sdca/sdca_function_device.h   |  15 +
>  sound/soc/sdca/sdca_functions.c         |  52 ++-
>  sound/soc/sdca/sdca_hid.c               |   3 -
>  sound/soc/sdca/sdca_interrupts.c        |  39 +-
>  sound/soc/sdca/sdca_regmap.c            |  89 +++--
>  15 files changed, 1089 insertions(+), 81 deletions(-)
>  create mode 100644 sound/soc/sdca/sdca_class.c
>  create mode 100644 sound/soc/sdca/sdca_class.h
>  create mode 100644 sound/soc/sdca/sdca_class_function.c
>  create mode 100644 sound/soc/sdca/sdca_function_device.c
>  create mode 100644 sound/soc/sdca/sdca_function_device.h

For the series:
Reviewed-by: Maciej Strozek <mstrozek@opensource.cirrus.com>

-- 
Regards,
Maciej