Linux Sound subsystem development
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Peng Fan" <peng.fan@nxp.com>, "Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Mark Brown" <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: codec: Remove pxa2xx-ac97.c
Date: Thu, 18 Sep 2025 09:15:23 +0200	[thread overview]
Message-ID: <fd5451a1-9720-417a-915c-1ee3149426f2@app.fastmail.com> (raw)
In-Reply-To: <20250918-audio-v1-1-e9d0df5c60d2@nxp.com>

On Thu, Sep 18, 2025, at 07:44, Peng Fan wrote:
> With commit ce79f3a1ad5f ("ARM: pxa: prune unused device support") and
> commit 2548e6c76ebf ("ARM: pxa: pxa2xx-ac97-lib: use IRQ resource"), there
> is no 'pxa2xx-ac97' platform device created by machine level code, so this
> driver could be removed.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  sound/arm/Kconfig       |  10 --
>  sound/arm/Makefile      |   3 -
>  sound/arm/pxa2xx-ac97.c | 286 ------------------------------------------------
>  3 files changed, 299 deletions(-)

I think you are right, I was sure there was still a way to use this
driver either as part of sound/soc/pxa/*, or as an alternative,
but now I don't see how.

If we do this, I think we should just merge pxa2xx-pcm-lib.c and
snd-pxa2xx-lib.c into the respective callers in the sound/soc/pxa/
driver.

Robert, can you confirm?

    Arnd

  reply	other threads:[~2025-09-18  7:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18  5:44 [PATCH 0/2] sound/arm: Remove pxa2xx-ac97.c and the defconfig reference Peng Fan
2025-09-18  5:44 ` [PATCH 1/2] ASoC: codec: Remove pxa2xx-ac97.c Peng Fan
2025-09-18  7:15   ` Arnd Bergmann [this message]
2025-10-25  9:13     ` Robert Jarzmik
2025-09-18  5:44 ` [PATCH 2/2] ARM: defconfig: remove CONFIG_SND_PXA2XX_AC97 references Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd5451a1-9720-417a-915c-1ee3149426f2@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox