From: Primoz Fiser <primoz.fiser@norik.com>
To: "Mark Brown" <broonie@kernel.org>,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
upstream@lists.phytec.de
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
Date: Fri, 7 Jun 2024 08:14:40 +0200 [thread overview]
Message-ID: <fe0ec57b-dad3-4666-abe3-75bcb65fa7df@norik.com> (raw)
In-Reply-To: <71d7754e-f72c-4a04-b03e-a0ee0e24c9e0@sirena.org.uk>
Hi,
On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
>
>>> - card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> - "HDMI %s", dev_name(ad->dssdev));
>>> - if (!card->name)
>>> - return -ENOMEM;
>>> -
>>> + card->name = DRV_NAME;
>
>> I think it would be better to name is simply "HDMI" instead
>
> That does seem a bit more user friendly.
So card->name = "HDMI" for v2?
Thanks,
BR,
Primoz
--
Primoz Fiser | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o. | https://www.norik.com
<https://www.norik.com> |
Your embedded software partner | email: info@norik.com
<mailto:info@norik.com> |
Slovenia, EU | phone: +386-41-540-545
<tel:+386-41-540-545> |
next prev parent reply other threads:[~2024-06-07 6:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 7:06 [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name Primoz Fiser
2024-06-06 18:00 ` Péter Ujfalusi
2024-06-06 18:01 ` Mark Brown
2024-06-07 6:14 ` Primoz Fiser [this message]
2024-06-07 15:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe0ec57b-dad3-4666-abe3-75bcb65fa7df@norik.com \
--to=primoz.fiser@norik.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox