A few sound drivers directly set pci_dev->dma_mask instead of calling pci_set_dma_mask. pci_dev.dma_mask may be moved soon (probably to pci_dev.device.dma_mask). So, applying this patch will reduce or eliminate the need to change your code when that happens, and it will be one less change to maintain between 2.4 and 2.5+ kernels. In one case, these changes also allow the driver to detect and fail if the DMA it wants really is not available, although I don't know how realistic that scenario is. If these changes look OK, then I would appreciate it if the appropriate maintainers would shepherd this patch to Linus or let me know if there is something more I should do. -- Adam J. Richter __ ______________ 575 Oroville Road adam@yggdrasil.com \ / Milpitas, California 95035 +1 408 309-6081 | g g d r a s i l United States of America "Free Software For The Rest Of Us."