From: Takashi Iwai <tiwai@suse.de>
To: linux-sound@vger.kernel.org
Subject: Re: OPL3SA2: spin_is_locked on uninitialized spinlock
Date: Wed, 13 Aug 2003 13:01:30 +0000 [thread overview]
Message-ID: <marc-linux-sound-106077994322726@msgid-missing> (raw)
In-Reply-To: <marc-linux-sound-106077529618070@msgid-missing>
At Wed, 13 Aug 2003 05:04:48 -0700,
Andrew Morton wrote:
>
> Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> wrote:
> >
> > I've found a lot of errors like this when loading the OPL3SA2 sound
> > driver on my old Intel AL440LX computer, running 2.6.0-test3-mm1:
> >
> > sound/isa/opl3sa2.c:204: spin_is_locked on uninitialized spinlock
> > d6200034.
>
> Does this help?
>
> diff -puN sound/isa/opl3sa2.c~opl3sa2-lock-init-fix sound/isa/opl3sa2.c
> --- 25/sound/isa/opl3sa2.c~opl3sa2-lock-init-fix 2003-08-13 05:03:32.000000000 -0700
> +++ 25-akpm/sound/isa/opl3sa2.c 2003-08-13 05:04:06.000000000 -0700
> @@ -752,6 +752,7 @@ static int __devinit snd_opl3sa2_probe(i
> err = -ENOMEM;
> goto __error;
> }
> + spin_lock_init(&chip->reg_lock);
> chip->irq = -1;
> if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0)
> goto __error;
oh yeah this one should fix. thanks.
--
Takashi Iwai <tiwai@suse.de> SuSE Linux AG - www.suse.de
ALSA Developer ALSA Project - www.alsa-project.org
next prev parent reply other threads:[~2003-08-13 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 11:39 OPL3SA2: spin_is_locked on uninitialized spinlock Felipe Alfaro Solana
2003-08-13 12:04 ` Andrew Morton
2003-08-13 13:01 ` Takashi Iwai [this message]
2003-08-13 13:34 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-sound-106077994322726@msgid-missing \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox