From: Takashi Iwai <tiwai@suse.de>
To: Oliver Neukum <oneukum@suse.de>
Cc: Jaroslav Kysela <perex@suse.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch]cleanup and error reporting for sound/core/init.c
Date: Fri, 12 Jan 2007 17:42:52 +0000 [thread overview]
Message-ID: <s5h64bcgmzn.wl%tiwai@suse.de> (raw)
In-Reply-To: <200701121449.58186.oneukum@suse.de>
At Fri, 12 Jan 2007 14:49:57 +0100,
Oliver Neukum wrote:
>
> + } else {
> + if (idx < snd_ecards_limit) {
> + if (snd_cards_lock & (1 << idx))
> + err = -EBUSY; /* invalid */
> + } else if (idx < SNDRV_CARDS)
> + snd_ecards_limit = idx + 1; /* increase the limit */
> + else
> + err = -ENODEV;
The indent looks strange in the above three lines.
Also, for me it's not much better than before... :)
(all if's are comparisons of idx with other values.)
Takashi
next prev parent reply other threads:[~2007-01-12 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 13:49 [patch]cleanup and error reporting for sound/core/init.c Oliver Neukum
2007-01-12 17:42 ` Takashi Iwai [this message]
2007-01-13 6:37 ` Oliver Neukum
2007-01-16 16:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h64bcgmzn.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox