Re: [PATCH 2/3] ASoC: cs42l43: Factor out decimator startup data to an array

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: cs42l43: missing static const on decim_info lookup tables
--

commit aad56061661af8b4127504548c049c31c4e54dca
Author: Charles Keepax <ckeepax@opensource.cirrus.com>

ASoC: cs42l43: Factor out decimator startup data to an array

This commit replaces the variant-specific switch statements in
cs42l43_mic_ev() with the cs42l43_decim_info and cs42l43b_decim_info lookup
arrays indexed by w->shift.

> diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c
> index 90c83bb33d69b..17d55a3de9de3 100644
> --- a/sound/soc/codecs/cs42l43.c
> +++ b/sound/soc/codecs/cs42l43.c
> @@ -1736,97 +1736,82 @@ static int cs42l43_hp_ev(struct snd_soc_dapm_widget *w,
>  	return 0;
>  }
>  
> +struct decim_info {
> +	unsigned int vreg;
> +	unsigned int vmask;
> +};
> +
> +struct decim_info cs42l43_decim_info[] = {
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM1_VD_RAMP_MASK | CS42L43_DECIM1_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM2_VD_RAMP_MASK | CS42L43_DECIM2_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM1_VD_RAMP_MASK | CS42L43_DECIM1_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM2_VD_RAMP_MASK | CS42L43_DECIM2_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH3_CH4,
> +		.vmask = CS42L43_DECIM3_VD_RAMP_MASK | CS42L43_DECIM3_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43_DECIM_VOL_CTRL_CH3_CH4,
> +		.vmask = CS42L43_DECIM4_VD_RAMP_MASK | CS42L43_DECIM4_MUTE_MASK,
> +	}
> +};
> +
> +struct decim_info cs42l43b_decim_info[] = {
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM1_VD_RAMP_MASK | CS42L43_DECIM1_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH1_CH2,
> +		.vmask = CS42L43_DECIM2_VD_RAMP_MASK | CS42L43_DECIM2_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH3_CH4,
> +		.vmask = CS42L43_DECIM3_VD_RAMP_MASK | CS42L43_DECIM3_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH3_CH4,
> +		.vmask = CS42L43_DECIM4_VD_RAMP_MASK | CS42L43_DECIM4_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH5_CH6,
> +		.vmask = CS42L43B_DECIM5_PATH1_VOL_FALL_RATE_MASK | CS42L43B_DECIM5_MUTE_MASK,
> +	},
> +	{
> +		.vreg = CS42L43B_DECIM_VOL_CTRL_CH5_CH6,
> +		.vmask = CS42L43B_DECIM6_PATH1_VOL_FALL_RATE_MASK | CS42L43B_DECIM6_MUTE_MASK,
> +	}
> +};
> +
>  static int cs42l43_mic_ev(struct snd_soc_dapm_widget *w,
>  			  struct snd_kcontrol *kcontrol, int event)
>  {
>  	struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
>  	struct cs42l43_codec *priv = snd_soc_component_get_drvdata(component);
> +	struct decim_info *info = &cs42l43_decim_info[w->shift];

[Severity: Low]
Should cs42l43_decim_info and cs42l43b_decim_info in
sound/soc/codecs/cs42l43.c be declared static const (and info in
cs42l43_mic_ev() be a const struct decim_info *)?

Both tables are only used within sound/soc/codecs/cs42l43.c and are never
modified. Without static const, they are placed in writable .data instead of
.rodata and trigger -Wmissing-variable-declarations and Sparse warnings when
building with W=1 or C=1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102155440.3995136-1-ckeepax@opensource.cirrus.com?part=2