Re: [PATCH v2 3/7] soundwire: intel: Split PDIs and DAIs initialization

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] soundwire: intel: redundant declaration of sdw_intel_init_pdis() in intel.h
--

commit b93a84bb66dfc11183e5241bb65db4b0c4fcaaef
Author: Cezary Rojewski <cezary.rojewski@intel.com>

soundwire: intel: Split PDIs and DAIs initialization

This commit splits PDI initialization out of intel_register_dai() into a
separate init_pdis callback in struct sdw_intel_hw_ops so that register_dai()
can be optional. It also updates intel_link_startup() to call
sdw_intel_init_pdis() before registering DAIs.

> diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h
> index 7a2e7e73ad632..f2372749f08db 100644
> --- a/drivers/soundwire/intel.h
> +++ b/drivers/soundwire/intel.h
> @@ -154,11 +154,18 @@ static inline void sdw_intel_debugfs_exit(struct sdw_intel *sdw)
>  		SDW_INTEL_OPS(sdw, debugfs_exit)(sdw);
>  }
>  
> +static inline int sdw_intel_init_pdis(struct sdw_intel *sdw)
> +{
> +	if (SDW_INTEL_CHECK_OPS(sdw, init_pdis))
> +		return SDW_INTEL_OPS(sdw, init_pdis)(sdw);
> +	return -ENOTSUPP;
> +}
> +
>  static inline int sdw_intel_register_dai(struct sdw_intel *sdw)
>  {
>  	if (SDW_INTEL_CHECK_OPS(sdw, register_dai))
>  		return SDW_INTEL_OPS(sdw, register_dai)(sdw);
> -	return -ENOTSUPP;
> +	return 0;
>  }
>  
>  static inline void sdw_intel_check_clock_stop(struct sdw_intel *sdw)
> @@ -262,6 +269,7 @@ int intel_start_bus_after_reset(struct sdw_intel *sdw);
>  void intel_check_clock_stop(struct sdw_intel *sdw);
>  int intel_start_bus_after_clock_stop(struct sdw_intel *sdw);
>  int intel_stop_bus(struct sdw_intel *sdw, bool clock_stop, bool wake_enable);
> +int sdw_intel_init_pdis(struct sdw_intel *sdw);

[Severity: Low]
sdw_intel_init_pdis() is already defined earlier in drivers/soundwire/intel.h
as a static inline wrapper for the init_pdis callback. Should this redundant
non-static prototype under the common bus management declarations be dropped?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103134958.2089136-1-cezary.rojewski@intel.com?part=3