Re: [PATCH] ASoC: imx-audmux: Convert to subsys_platform_driver()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ASoC: imx-audmux: undefined macro subsys_platform_driver() breaks build
--

commit 9704777f69127c7bff10f89c72ce44590893c56e
Author: Peng Fan <peng.fan@nxp.com>

ASoC: imx-audmux: Convert to subsys_platform_driver()

This commit replaces the open-coded subsys_initcall() and module_exit()
registration of imx_audmux_driver with subsys_platform_driver().

> diff --git a/sound/soc/fsl/imx-audmux.c b/sound/soc/fsl/imx-audmux.c
> index f8335a04595a7..d46f43ab66cf6 100644
> --- a/sound/soc/fsl/imx-audmux.c
> +++ b/sound/soc/fsl/imx-audmux.c
> @@ -361,18 +361,7 @@ static struct platform_driver imx_audmux_driver = {
>  		.of_match_table = imx_audmux_dt_ids,
>  	}
>  };
> -
> -static int __init imx_audmux_init(void)
> -{
> -	return platform_driver_register(&imx_audmux_driver);
> -}
> -subsys_initcall(imx_audmux_init);
> -
> -static void __exit imx_audmux_exit(void)
> -{
> -	platform_driver_unregister(&imx_audmux_driver);
> -}
> -module_exit(imx_audmux_exit);
> +subsys_platform_driver(imx_audmux_driver);

[Severity: High]
Does subsys_platform_driver() exist in the kernel tree?

Looking at include/linux/platform_device.h, only module_platform_driver(),
builtin_platform_driver(), module_platform_driver_probe(), and
builtin_platform_driver_probe() are defined:

    #define module_platform_driver(__platform_driver) \
    	module_driver(__platform_driver, platform_driver_register, \
    			platform_driver_unregister)

    #define builtin_platform_driver(__platform_driver) \
    	builtin_driver(__platform_driver, platform_driver_register)

Because subsys_platform_driver() is not defined anywhere, building
sound/soc/fsl/imx-audmux.c with CONFIG_SND_SOC_IMX_AUDMUX enabled fails to
compile and leaves imx_audmux_driver unregistered. Was this patch depending
on a prerequisite patch that introduces subsys_platform_driver()?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104113228.1634005-1-peng.fan@oss.nxp.com?part=1