Re: [PATCH v3 3/7] soundwire: intel: Split PDIs and DAIs initialization

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] soundwire: intel: bypassing intel_register_dai() against
  maintainer direction
--

commit fd70be11c65e2cabc3b8e75299a0c79a70299383
Author: Cezary Rojewski <cezary.rojewski@intel.com>

soundwire: intel: Split PDIs and DAIs initialization

This commit splits PDI initialization out of intel_register_dai() into a
separate init_pdis() callback and makes the register_dai() callback
optional during link startup.

> diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h
> index 7a2e7e73ad632..65f7d53a3d2b4 100644
> --- a/drivers/soundwire/intel.h
> +++ b/drivers/soundwire/intel.h
> @@ -154,11 +154,18 @@ static inline void sdw_intel_debugfs_exit(struct sdw_intel *sdw)
>  		SDW_INTEL_OPS(sdw, debugfs_exit)(sdw);
>  }
>  
> +static inline int sdw_intel_init_pdis(struct sdw_intel *sdw)
> +{
> +	if (SDW_INTEL_CHECK_OPS(sdw, init_pdis))
> +		return SDW_INTEL_OPS(sdw, init_pdis)(sdw);
> +	return -ENOTSUPP;
> +}
> +
>  static inline int sdw_intel_register_dai(struct sdw_intel *sdw)
>  {
>  	if (SDW_INTEL_CHECK_OPS(sdw, register_dai))
>  		return SDW_INTEL_OPS(sdw, register_dai)(sdw);
> -	return -ENOTSUPP;
> +	return 0;
>  }

[Severity: Medium]
As reported by Pierre-Louis Bossart on v2 [1], can the AVS driver reuse
the existing SoundWire Intel DAI registration and intel_pcm_dai_ops
rather than making register_dai() optional to bypass them?

Splitting intel_init_pdis() from intel_register_dai() and returning 0 when
register_dai is NULL is only used so commit "ASoC: Intel: avs: SoundWire
support" and commit "ASoC: Intel: avs: SoundWire PCM BE operations" can
clear register_dai and implement a separate DAI registration and dynamic
PDI assignment path, duplicating the existing SoundWire Intel DAI
infrastructure.

[1] https://lore.kernel.org/r/bcfe64de-359c-4f16-9014-5d6f8bf30c40@linux.dev

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106121557.2338556-1-cezary.rojewski@intel.com?part=3