Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sreeraj S Kurup" <sreekuttan2156239@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: control: Fix parsing of numeric fields
Date: Fri, 06 Nov 2026 15:54:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-201744@kernel.org> (raw)
In-Reply-To: <20261106154545.2973-1-sreekuttan2156239@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: control: missing Fixes trailer for parse_uint() bug fix
--

commit 1bd2d3e81b83fc5553191929745f26253824ba8d
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: control: Fix parsing of numeric fields
>
> parse_uint() passes the remaining input string to kstrtoull().
>
> When the input contains comma-separated fields, the string
> contains both the numeric value and the following fields.
>
> For example, with:
>
> device=1,subdevice=0,name=Master
>
> kstrtoull() receives "1,subdevice=0,name=Master" and fails
> to parse the numeric value.
>
> Stop parsing at the next comma and pass only the numeric
> field to kstrtouint().
>
> This allows numeric fields to be parsed correctly in
> comma-separated input.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
This fixes a bug in the sysfs kcontrol LED parser.  Should it include:

  Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking layer")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106154545.2973-1-sreekuttan2156239@gmail.com?part=1

  reply	other threads:[~2026-11-06 15:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:45 [PATCH] ALSA: control: Fix parsing of numeric fields Sreeraj S Kurup
2026-11-06 15:54 ` sashiko-bot [this message]
2026-11-06 16:23 ` [PATCH v2] " Sreeraj S Kurup
2026-11-08  9:54   ` Sreeraj S Kurup
2026-11-08 10:44     ` Takashi Iwai
2026-11-08 11:18       ` Sreeraj S Kurup
2026-11-08 12:06         ` Takashi Iwai
2026-11-08 12:47           ` Sreeraj S Kurup
2026-11-08 12:48           ` [PATCH v3] " Sreeraj S Kurup
2026-11-08 16:48             ` Manuel Ebner
2026-11-09 14:33             ` Takashi Iwai
2026-11-09 15:58               ` Sreeraj S Kurup
2026-11-09 15:59             ` [PATCH v4] " Sreeraj S Kurup
2026-11-09 16:07               ` sashiko-bot
2026-11-09 16:35             ` [PATCH v5] " Sreeraj S Kurup
2026-11-10 10:27               ` Takashi Iwai
2026-11-11 10:56                 ` Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201744@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox