Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sreeraj S Kurup" <sreekuttan2156239@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: control: Trim whitespace from sysfs input
Date: Fri, 06 Nov 2026 17:02:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-201891@kernel.org> (raw)
In-Reply-To: <20261106165531.4074-1-sreekuttan2156239@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: control: missing Fixes trailer for set_led_id() whitespace
  fix
--

commit fba9994b6098b77ca57c53a57ff6876210ceae6a
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: control: Trim whitespace from sysfs input
>
> The attach and detach sysfs interfaces receive input from
> userspace.
>
> When userspace writes a value using echo, the input normally
> ends with a newline character.
>
> The parser does not remove this newline in all input formats.
> For example, a bare numeric ID can be treated as a control name,
> and an unquoted name= field can include the newline.
>
> Trim leading and trailing whitespace before parsing the input.
>
> This keeps spaces inside mixer control names unchanged.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
Since this fixes newline handling in set_led_id(), should it include:

  Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking layer")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106165531.4074-1-sreekuttan2156239@gmail.com?part=1

  reply	other threads:[~2026-11-06 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 16:55 [PATCH] ALSA: control: Trim whitespace from sysfs input Sreeraj S Kurup
2026-11-06 17:02 ` sashiko-bot [this message]
2026-11-06 17:26 ` [PATCH v2] " Sreeraj S Kurup
2026-11-07  9:03   ` Takashi Iwai
2026-11-07 11:49     ` Sreeraj S Kurup
2026-11-07 11:51     ` Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201891@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox