Re: [PATCH v2] ASoC: dt-bindings: wm8741: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [Medium] ASoC: dt-bindings: wm8741: diff-mode placed at root level of
  YAML schema
- [Medium] ASoC: dt-bindings: wm8741: invalid example bus addressing and
  trailing spaces
- [Low] ASoC: dt-bindings: wm8741: missing supplies, DAI, and SPI
  properties in schema
- [Low] ASoC: dt-bindings: wm8741: dangling sound/wm* file entry in
  MAINTAINERS
--

commit 9c3870a4814d3bc22a021bf5687bbcb6d6e76c1c
Author: Lorena Tanase <tanaselorena3@gmail.com>

ASoC: dt-bindings: wm8741: Convert to DT schema

This commit converts the Wolfson Microelectronics wm8741 audio codec device
tree binding from plain text to yaml schema format.

> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml
> new file mode 100644
> index 0000000000000..a9a7fc2414bb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml
> @@ -0,0 +1,40 @@
[ ... ]
> +properties:
> +  compatible:
> +    const: wlf,wm8741
> +
> +  reg:
> +    maxItems: 1

[Severity: Low]
Should this schema also document the regulator supplies, #sound-dai-cells,
and spi peripheral properties?

Both wm8741_i2c_probe() and wm8741_spi_probe() in sound/soc/codecs/wm8741.c
request the avdd and dvdd supplies via devm_regulator_bulk_get(), and the
device supports both i2c and spi buses:

sound/soc/codecs/wm8741.c:
static const char *wm8741_supply_names[WM8741_NUM_SUPPLIES] = {
	"AVDD",
	"DVDD",
};

Because the schema sets additionalProperties: false, device tree nodes for
wlf,wm8741 that specify avdd-supply, dvdd-supply, #sound-dai-cells, or spi
properties such as spi-max-frequency will fail dtbs_check unless those
properties and refs to dai-common.yaml# and
/schemas/spi/spi-peripheral-props.yaml# (with unevaluatedProperties: false)
are included.

> +
> +diff-mode:
> +  description: diferential output mode
> +  $ref: /schemas/types.yaml#/definitions/uint32
> +  enum: [0, 1, 2, 3]
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Medium]
Is diff-mode placed at the root of the document instead of indented under
properties?

At column 0, diff-mode is rejected by dt-doc-validate as an unknown
top-level keyword during make dt_binding_check, and any node using
diff-mode (including the example below) fails validation against
additionalProperties: false.

Compared to wm8741.txt, this entry also drops default: 0 and the
descriptions of the four mode values (0 = stereo, 1 = mono left,
2 = stereo reversed, 3 = mono right), and misspells differential as
diferential.

> +
> +examples:
> +  - |
> +    wm8903: codec@1a {
> +      compatible = "wlf,wm8741";
> +      reg = <0x1a>;
> +
> +      diff-mode = <3>;    
> +    };

[Severity: Medium]
Should codec@1a in the example be wrapped in an i2c or spi bus node?

Without a parent bus node setting #address-cells = <1> and
#size-cells = <0>, dt-extract-example uses the default root cell sizes of 1
and 1, causing dtc to fail on reg = <0x1a> with a reg_format error during
make dt_binding_check.

The diff-mode = <3>; line also has four trailing spaces that cause yamllint
to fail, and the node uses an unused wm8903 label with 2-space indentation
instead of standard 4-space example indentation.

> diff --git a/Documentation/devicetree/bindings/sound/wm8741.txt b/Documentation/devicetree/bindings/sound/wm8741.txt
> deleted file mode 100644
> index b69e196c741c4..0000000000000
> --- a/Documentation/devicetree/bindings/sound/wm8741.txt
> +++ /dev/null

[Severity: Low]
Does removing Documentation/devicetree/bindings/sound/wm8741.txt leave a
dangling file pattern in the maintainers file?

wm8741.txt was the last file matching
Documentation/devicetree/bindings/sound/wm*, while the new yaml file is
already covered by Documentation/devicetree/bindings/sound/wlf,*.yaml, so
get_maintainer.pl --self-test=patterns will warn unless the sound/wm* entry
is removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109165522.6663-1-tanaselorena3@gmail.com?part=1