Re: [PATCH v2 5/6] ASoC: dwc: Propagate optional IRQ lookup errors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ASoC: dwc: unbalanced reset deassert in dw_i2s_probe() on IRQ
  error
--

commit f22e35683fe4bb23831ac84cbbbb8c5cfc290ae0
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: dwc: Propagate optional IRQ lookup errors

This commit updates dw_i2s_probe() to propagate errors other than -ENXIO
from platform_get_irq_optional() using dev_err_probe().

> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index b0d3413c27d2b..0d2be2d8d31ae 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -961,8 +961,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
>  	}
>  
>  	irq = platform_get_irq_optional(pdev, 0);
> -	if (irq == -EPROBE_DEFER)
> -		return irq;
> +	if (irq < 0 && irq != -ENXIO)
> +		return dev_err_probe(&pdev->dev, irq, "failed to get IRQ\n");

[Severity: Medium]
Does returning directly here leave dev->reset deasserted when
platform_get_irq_optional() fails?

Just before the IRQ lookup, dw_i2s_probe() manually deasserts the shared
reset control via reset_control_deassert(dev->reset), and later failure
paths jump to err_assert_reset to call reset_control_assert(dev->reset).
Bypassing err_assert_reset leaves the hardware reset line deasserted and
leaks a deassert reference on the shared reset control.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110095525.504660-1-phucduc.bui@gmail.com?part=5