From: sashiko-bot@kernel.org
To: fixca <jaehoon1744@dankook.ac.kr>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/2] ASoC: amd: acp: Add ACP70 ACPI flag override for LG gram 16Z95U
Date: Wed, 11 Nov 2026 02:27:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-208084@kernel.org> (raw)
In-Reply-To: <20261111013953.4011-2-jaehoon1744@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: amd: acp: non-standard Co-Authored-By trailer for AI
assistant
--
commit 91210b0f73b2ab770e122848ab0f260ad48765be
Author: Jaehoon Kim <jaehoon1744@dankook.ac.kr>
> ASoC: amd: acp: Add ACP70 ACPI flag override for LG gram 16Z95U
>
> The LG gram 16 (16Z95U, AMD Ryzen AI 400 series, ACP rev 0x72) BIOS
> sets "acp-audio-config-flag" to 0x10 (FLAG_AMD_LEGACY_ONLY_DMIC), but
> the machine has no ACP PDM microphone. All audio endpoints are
> SoundWire peripherals declared under the ACP SoundWire controller:
>
> link 0: RT713 (UAJ + SmartMic functions), _ADR 0x000030025D071301
> link 1: RT1320 (SmartAmp function), _ADR 0x000131025D132001
>
> With the flag honoured, snd_pci_ps bails out with -ENODEV, the legacy
> snd_acp_pci driver binds instead and fails with:
>
> platform acp_asoc_acp70.0: warning: No matching ASoC machine driver found
>
> so no sound card is created at all.
>
> Add the machine to acp70_acpi_flag_override_table so that the
> SoundWire path is used.
>
> Tested on LG gram 16Z95U-GS59K (PCI SSID 1854:056c): with this change
> snd_pci_ps binds and both peripherals enumerate
> (sdw:0:0:025d:0713:01, sdw:0:1:025d:1320:01).
>
> Signed-off-by: Jaehoon Kim <jaehoon1744@dankook.ac.kr>
> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Severity: Low]
Co-Authored-By: is not a recognized kernel signature tag and triggers
scripts/checkpatch.pl warnings. Kernel co-authorship uses
Co-developed-by: paired with a human co-author's Signed-off-by: certifying
the Developer Certificate of Origin, which an AI tool cannot provide; per
Documentation/process/generated-content.rst, AI assistance can be
disclosed in the changelog or attributed with Assisted-by: instead.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111013953.4011-1-jaehoon1744@gmail.com?part=1
next prev parent reply other threads:[~2026-11-11 2:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 1:39 [PATCH RFC v2 0/2] ASoC: amd: SoundWire audio for LG gram 16Z95U (rt713 + rt1320), speaker still silent fixca
2026-11-11 1:39 ` [PATCH RFC v2 1/2] ASoC: amd: acp: Add ACP70 ACPI flag override for LG gram 16Z95U fixca
2026-11-11 1:57 ` Mukunda,Vijendar
2026-11-11 2:27 ` sashiko-bot [this message]
2026-11-11 1:39 ` [PATCH RFC v2 2/2] ASoC: amd: acp70: Add rt713 + rt1320 SoundWire machine " fixca
2026-11-11 2:05 ` Mukunda,Vijendar
2026-11-11 1:55 ` [PATCH RFC v2 0/2] ASoC: amd: SoundWire audio for LG gram 16Z95U (rt713 + rt1320), speaker still silent Mukunda,Vijendar
2026-11-11 2:20 ` Mark Brown
2026-11-12 4:01 ` [PATCH RFC 0/1] ASoC: rt1320: LG gram 16Z95U speaker works with the BIOS init values fixca
2026-11-12 4:01 ` [PATCH RFC 1/1] ASoC: rt1320: Use the BIOS init values on LG gram 16Z95U fixca
2026-11-12 4:15 ` sashiko-bot
2026-11-12 4:46 ` [PATCH RFC 0/1] ASoC: rt1320: LG gram 16Z95U speaker works with the BIOS init values fixca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208084@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jaehoon1744@dankook.ac.kr \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox