From: sashiko-bot@kernel.org
To: "Fa-Iz Faadhillah Ibrahim" <faiz.faadhillah@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72
Date: Wed, 11 Nov 2026 02:48:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-208117@kernel.org> (raw)
In-Reply-To: <20261111021328.16153-1-faiz.faadhillah@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] ALSA: hda/realtek: duplicate 0x1025:0x1731 quirk entry in
alc269_fixup_tbl
- [Low] ALSA: hda/realtek: missing Fixes trailer for commit 34e08ad3a8da
--
commit 5bafc10ed11e5fc65c61bd076960d71905ca3545
Author: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>
> ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72
>
> fix micmute LED for Acer Predator PHN16-72.
>
> Signed-off-by: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>
[Severity: Low]
Since this updates the incomplete quirk added in 34e08ad3a8da ("ALSA:
hda/realtek: Add quirk for Acer Predator PHN16-72"), should this include:
Fixes: 34e08ad3a8da ("ALSA: hda/realtek: Add quirk for Acer Predator PHN16-72")
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index a756e0076021a..fa78a36bba5ff 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7553,6 +7553,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1025, 0x170f, "Acer Predator PHN16-71", ALC2XX_FIXUP_HEADSET_MIC),
> SND_PCI_QUIRK(0x1025, 0x171e, "Acer Nitro ANV15-51", ALC245_FIXUP_ACER_MICMUTE_LED),
> SND_PCI_QUIRK(0x1025, 0x172c, "Acer Nitro ANV16-41", ALC2XX_FIXUP_HEADSET_MIC),
> + SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC245_FIXUP_ACER_MICMUTE_LED),
> SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC2XX_FIXUP_HEADSET_MIC),
[Severity: Low]
Should this replace the existing 0x1025:0x1731 entry in alc269_fixup_tbl
rather than adding a second entry above it? snd_hda_pick_fixup() stops at
the first matching SSID, and ALC245_FIXUP_ACER_MICMUTE_LED already chains
ALC2XX_FIXUP_HEADSET_MIC, leaving the second 0x1025:0x1731 entry
unreachable.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111021328.16153-1-faiz.faadhillah@gmail.com?part=1
next prev parent reply other threads:[~2026-11-11 2:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 2:13 [PATCH] ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72 Fa-Iz Faadhillah Ibrahim
2026-11-11 2:48 ` sashiko-bot [this message]
2026-11-11 8:59 ` Takashi Iwai
2026-11-11 12:45 ` Fa-Iz Faadhillah Ibrahim
2026-11-11 15:39 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208117@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=faiz.faadhillah@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox