From: sashiko-bot@kernel.org
To: guanlan@awinic.com, "open list:SOUND" <linux-sound@vger.kernel.org>
Subject: Re: [PATCH] ASoC: hda/realtek: Add support for Lenovo Hudson
Date: Wed, 11 Nov 2026 04:45:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-208312@kernel.org> (raw)
In-Reply-To: <20261111043601.306427-1-guanlan@awinic.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: hda/realtek: duplicate and unsorted 17aa:3814 quirks in
alc269_fixup_tbl
--
commit 7ce4d2a12d39225f2afc7745135304f988537c37
Author: Tao Xiao <guanlan@awinic.com>
ASoC: hda/realtek: Add support for Lenovo Hudson
This commit adds ALC287_FIXUP_LENOVO_LEGION_AW88399 quirk entries and an
AW88399 channel-swap entry for the Lenovo Hudson (SSID 17aa:3814).
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index a756e0076021a..b33bd4efb51c8 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -8664,8 +8664,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> HDA_CODEC_QUIRK(0x17aa, 0x3937, "Legion R9000P ADR10H", ALC287_FIXUP_LENOVO_LEGION_AW88399),
> HDA_CODEC_QUIRK(0x17aa, 0x3938, "Legion Pro 7 16AFR10H", ALC287_FIXUP_LENOVO_LEGION_AW88399),
> HDA_CODEC_QUIRK(0x17aa, 0x3939, "Legion Pro 7 16AFR10H", ALC287_FIXUP_LENOVO_LEGION_AW88399),
> + HDA_CODEC_QUIRK(0x17aa, 0x3814, "Lenovo Hudson", ALC287_FIXUP_LENOVO_LEGION_AW88399),
> SND_PCI_QUIRK(0x17aa, 0x393e, "Lenovo ThinkBook 14 G8+ IPH", ALC287_FIXUP_LENOVO_XPAD_HEADSET_JACK),
> HDA_CODEC_QUIRK(0x17aa, 0x394c, "Lenovo Yoga Slim 7 14AGP11", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> + SND_PCI_QUIRK(0x17aa, 0x3814, "Lenovo Hudson", ALC287_FIXUP_LENOVO_LEGION_AW88399),
[Severity: Low]
Why are both HDA_CODEC_QUIRK and SND_PCI_QUIRK added for 0x17aa:0x3814 in
alc269_fixup_tbl, and placed after the 0x39xx entries?
snd_hda_pick_fixup() scans alc269_fixup_tbl sequentially and falls back to
hda_quirk_lookup_id() on the codec SSID across all entries, so one entry is
redundant when both entries map 0x17aa:0x3814 to the same fixup. In
addition, alc269_fixup_tbl is sorted by subvendor and subdevice ID (so
0x3814 belongs between 0x3813 and 0x3818), and placing HDA_CODEC_QUIRK at
the end of the 0x39xx block means any shared PCI SSID earlier in the
0x17aa range would match before this HDA_CODEC_QUIRK is reached.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111043601.306427-1-guanlan@awinic.com?part=1
next prev parent reply other threads:[~2026-11-11 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 4:36 [PATCH] ASoC: hda/realtek: Add support for Lenovo Hudson guanlan
2026-11-11 4:45 ` sashiko-bot [this message]
2026-11-11 14:27 ` Marco Giunta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208312@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=guanlan@awinic.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox