Re: [PATCH v2 3/5] soundwire: Select the correct runtime for lane allocation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: missing Fixes trailer for sdw_compute_bus_params()
  lane fix
--

commit b1efaa73284b1d94c7492050c9026885c088a497
Author: Bard Liao <yung-chuan.liao@linux.intel.com>

> soundwire: Select the correct runtime for lane allocation
>
> When multiple master runtimes exist on the same bus,
> sdw_compute_bus_params() selects the first runtime for which an
> additional lane is available. This can select an already running stream
> instead of the stream being prepared.
>
> Changing that runtime's port lanes accounts for its bandwidth again.
> If preparing the new stream fails, restoring the bus parameters leaves
> the active stream's lanes inconsistent with its bandwidth reservation.
> Depreparing the active stream can then underflow the lane bandwidth and
> leave lane 0 bandwidth reserved.
>
> Pass the current stream and prepare context to sdw_compute_bus_params()
> and restrict lane allocation to that stream's runtime during prepare.
> Skip lane allocation during deprepare, when its bandwidth reservation
> has already been released. Keep clock recomputation and the existing
> group and port filtering unchanged.
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>

[Severity: Low]
This fixes the unqualified bus->m_rt_list loop in sdw_compute_bus_params().
Should this include a Fixes tag:

  Fixes: 7a30292ffa2a ("soundwire: generic_bandwidth_allocation: select data lane")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112072105.1296515-1-yung-chuan.liao@linux.intel.com?part=3