Re: [RESEND PATCH 1/3] ASoC: codecs: lpass: Discard pm_runtime_put_autosuspend() return values

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] ASoC: codecs: lpass-rx-macro: missing probe deferral in
  rx_macro_probe() [1]
--

commit 0df95183a384e1e17bae628755bf6ae48d5ffec1
Author: Brian Norris <briannorris@chromium.org>

ASoC: codecs: lpass: Discard pm_runtime_put_autosuspend() return values

This commit drops error checks and warning messages on the return value of
pm_runtime_put_autosuspend() across the LPASS macro codec drivers.

> diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
> index ab8a1c2b0489b..c703275fc4429 100644
> --- a/sound/soc/codecs/lpass-rx-macro.c
> +++ b/sound/soc/codecs/lpass-rx-macro.c
> @@ -3919,9 +3919,7 @@ static int rx_macro_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_rpm_put;
>  
> -	ret = pm_runtime_put_autosuspend(dev);
> -	if (ret < 0)
> -		dev_warn(dev, "runtime PM put failed after probe: %d\n", ret);
> +	pm_runtime_put_autosuspend(dev);
>  
>  	return 0;
>  

[Severity: Medium]
This problem wasn't introduced by this patch, but can rx_macro_probe() fail
permanently [1] when it runs before the lpass-va-macro driver has
probed?

sound/soc/codecs/lpass-rx-macro.c:rx_macro_probe() {
	...
	rx->codec_version = lpass_macro_get_codec_version();
	...
	switch (rx->codec_version) {
	...
	default:
		dev_err(dev, "Unsupported Codec version (%d)\n", rx->codec_version);
		return -EINVAL;
	}
	...
}

Until va_macro_probe() sets the codec version, lpass_macro_get_codec_version()
returns LPASS_CODEC_VERSION_UNKNOWN (0).  Returning -EINVAL instead of
-EPROBE_DEFER causes the driver core to abandon probing rather than retrying
once the VA macro driver probes, breaking audio playback.

[1] https://sashiko.dev/#/bug/linux-263ddc0b-b9b3-4b30-bcac-0a188381f702

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112111937.RESEND.1.I5cd238b1d4516d4d6980565e0a4e1b83d9abce63@changeid?part=1