Re: [PATCH] ALSA: compress: Set metadata_set only after successful callback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: compress: missing Fixes trailer for commit 9727b490e543
--

commit 965fa8b5eac2d0c56694f06c6f1691a5d9ac92a3
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: compress: Set metadata_set only after successful callback
>
> Set the metadata_set flag only when the driver's set_metadata()
> callback completes successfully.
>
> Previously, the flag was set even when the callback returned an
> error. This incorrectly indicated that metadata had been applied
> successfully, potentially causing later operations to skip metadata
> setup.
>
> Update the flag only when the callback returns zero so that its
> state accurately reflects successful metadata submission.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
Should this commit include a Fixes tag for the commit that introduced the
unconditional assignment in snd_compr_set_metadata()?

  Fixes: 9727b490e543 ("ALSA: compress: add support for gapless playback")

Also, this isn't a bug in the patch, but stream->metadata_set is only read
in snd_compr_next_track() to gate SNDRV_COMPRESS_NEXT_TRACK (returning
-EPERM when false), rather than causing later operations to skip metadata
setup.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113091159.2954-1-sreekuttan2156239@gmail.com?part=1