Re: [PATCH RFC 03/23] dt-bindings: pinctrl: qcom,sm8650-lpass-lpi-pinctrl: document clocks and power domaines when ADSP is not used

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: pinctrl: qcom,sm8650-lpass-lpi-pinctrl: redundant
  oneOf in clocks
--

commit d8422bb265d6e088cce5d6024805eb9ced00d38a
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: pinctrl: qcom,sm8650-lpass-lpi-pinctrl: document clocks and power domaines when ADSP is not used

This commit updates the SM8650 LPASS LPI pinctrl DT binding schema to
allow a single core clock and add power-domains properties for platforms
where the ADSP is bypassed.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8650-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8650-lpass-lpi-pinctrl.yaml
> index 1bf08860a4baf..4c54f873199cc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8650-lpass-lpi-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8650-lpass-lpi-pinctrl.yaml
> @@ -29,11 +29,25 @@ properties:
>        - description: LPASS LPI TLMM Control and Status registers
>  
>    clocks:
> -    items:
> -      - description: LPASS Core voting clock
> -      - description: LPASS Audio voting clock
> +    oneOf:
> +      - items:   # for ADSP based platforms
> +          - description: LPASS Core voting clock
> +          - description: LPASS Audio voting clock
> +      - items:   # for ADSP bypass based platforms
> +          - description: LPASS Core voting clock
>  
>    clock-names:
> +    oneOf:
> +      - items:   # for ADSP based platforms
> +          - const: core
> +          - const: audio
> +      - items:   # for ADSP bypass based platforms
> +          - const: core

[Severity: Low]
Could clocks and clock-names set minItems: 1 alongside the two-entry
items list instead of using oneOf?  Because the single-entry ADSP bypass
list is a strict prefix of the two-entry list, minItems: 1 avoids
duplicating the first item in both properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-topic-sm8650-el2-v1-0-5183f6aab9fc@linaro.org?part=3