Re: [PATCH 1/2] ASoC: dt-bindings: Add NXP TFA9865 amplifier

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: dt-bindings: redundant sound-name-prefix in
  nxp,tfa9865.yaml
--

commit cf7a1e88df6af54e01055454b9dbda2662c5f8d6
Author: Venkat Yadlapati <venkat.yadlapati@yahoo.com>

ASoC: dt-bindings: Add NXP TFA9865 amplifier

This commit adds the Devicetree binding schema and MAINTAINERS entry for
the NXP TFA9865 mono class-D speaker amplifier.

> diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml
> new file mode 100644
> index 0000000000000..955e25abe7494
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nxp,tfa9865.yaml
> @@ -0,0 +1,65 @@

[ ... ]

> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: nxp,tfa9865
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vddd-supply:
> +    description: Digital supply (1.8 V)
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  sound-name-prefix: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#sound-dai-cells'
> +
> +unevaluatedProperties: false

[Severity: Low]
Is sound-name-prefix: true needed here?  dai-common.yaml# references
component-common.yaml#, which already defines sound-name-prefix, and
unevaluatedProperties: false permits properties from referenced allOf
schemas without re-listing them when no extra constraints are added.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-vantage-tfa9865-v1-0-e88f0dccc427@yahoo.com?part=1