Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: atmel-classd: Enable pclk during probe
Date: Mon, 16 Nov 2026 04:39:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-216193@kernel.org> (raw)
In-Reply-To: <20261116042633.497423-3-phucduc.bui@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: atmel-classd: missing Fixes trailer for pclk leak in
  atmel_classd_cpu_dai_startup()
--

commit 649a4204c070ced412b97a23b481af5d990b2be5
Author: bui duc phuc <phucduc.bui@gmail.com>

> ASoC: atmel-classd: Enable pclk during probe
>
> The peripheral clock is enabled in the startup callback but never
> disabled, causing its enable reference count to increase on each
> startup and preventing the clock from being gated.
>
> Use devm_clk_get_enabled() to enable pclk once during probe and
> automatically disable it on device removal.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

[Severity: Low]
Commit 1dfdbe73ccf9 ("ASoC: atmel-classd: remove codec component") merged
the codec and CPU DAI callbacks, dropping clk_disable_unprepare(dd->pclk)
from atmel_classd_cpu_dai_shutdown() while leaving clk_prepare_enable(dd->pclk)
in atmel_classd_cpu_dai_startup().  Should this include a Fixes tag?

  Fixes: 1dfdbe73ccf9 ("ASoC: atmel-classd: remove codec component")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116042633.497423-1-phucduc.bui@gmail.com?part=2

  reply	other threads:[~2026-11-16  4:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  4:26 [PATCH v2 0/2] ASoC: atmel-classd: Improve clock and probe handling phucduc.bui
2026-11-16  4:26 ` [PATCH v2 1/2] ASoC: atmel-classd: Simplify probe error handling phucduc.bui
2026-11-16  4:26 ` [PATCH v2 2/2] ASoC: atmel-classd: Enable pclk during probe phucduc.bui
2026-11-16  4:39   ` sashiko-bot [this message]
2026-11-16  4:54     ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216193@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=phucduc.bui@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox