Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV
Date: Mon, 16 Nov 2026 22:07:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-217774@kernel.org> (raw)
In-Reply-To: <20261116-omap-mcbsp-tdm-slot-v1-1-6c9f7aa45a29@telaak.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: ti: omap-mcbsp: missing Fixes trailer for CLKGDV() bitmask
  fix
--

commit 57823beda79b4dd439c729a38d2ffc6f36886577
Author: Joseph Telaak <joseph@telaak.dev>

> ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV
>
> CLKGDV is bits 7:0 of SRGR1, as its comment says and as set_clkdiv()
> intends with CLKGDV(0xff), but the macro masks the value with 0x7f, so
> a divider above 128 is written modulo 128.
>
> Mask with 0xff. The only set_clkdiv() user, omap3pandora, divides by 8,
> so nothing changes for it; this lets the set_tdm_slot() support that
> follows use dividers up to 256.
>
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

[Severity: Low]
Since this fixes the 7-bit mask introduced in 81da6a9e49b9 ("ASoC: OMAP:
mcbsp.h: Clean up bit definitions"), should it include a Fixes tag?

  Fixes: 81da6a9e49b9 ("ASoC: OMAP: mcbsp.h: Clean up bit definitions")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-omap-mcbsp-tdm-slot-v1-0-6c9f7aa45a29@telaak.dev?part=1

  reply	other threads:[~2026-11-16 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:03 [PATCH 0/2] ASoC: ti: omap-mcbsp: TDM slots for generic cards Joseph Telaak
2026-11-16 22:03 ` [PATCH 1/2] ASoC: ti: omap-mcbsp: Use all 8 bits of CLKGDV Joseph Telaak
2026-11-16 22:07   ` sashiko-bot [this message]
2026-11-16 22:03 ` [PATCH 2/2] ASoC: ti: omap-mcbsp: Implement set_tdm_slot Joseph Telaak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217774@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=joseph@telaak.dev \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox