From: sashiko-bot@kernel.org
To: "Qianghua Wang" <qianghua.wang@senarytech.com>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: sn624x: skip DMIC when ACPI DisCo has no MIC function
Date: Tue, 17 Nov 2026 03:02:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-218111@kernel.org> (raw)
In-Reply-To: <20261117024623.2122935-1-qianghua.wang@senarytech.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: sn624x: missing commit subject in Fixes trailer
--
commit 64d42df811f50125a7da965ef29c56e2c45716e7
Author: Qianghua Wang <qianghua.wang@senarytech.com>
> ASoC: sn624x: skip DMIC when ACPI DisCo has no MIC function
>
> Some OEM platforms, such as certain Samsung designs, use Senary SN624x
> for headset jack and speaker playback only: ACPI _DSD DisCo describes
> jack and speaker amp SDCA functions but omits the MIC array function
> because no on-board DMIC is routed to the codec. The driver still
> advertised the DMIC capture port and ran DMIC function init against
> registers that DisCo does not expose, which breaks bring-up on these
> machines.
>
> Probe the parsed DisCo function list before exposing the DMIC port and
> before running DMIC init. Apply AMP function init from the ACPI init
> tables when an amp function is present, using the same pattern as the
> existing jack and DMIC paths.
>
> Only omit DMIC when DisCo is present but lists no MIC function, so
> platforms without DisCo still use the OEM DMIC fallback. Do not fail amp
> init when there is no ACPI init table. Re-apply amp init tables after
> re-attach when FUN STATUS is idle but DisCo still supplies a table.
>
> Fixes: 12d9c9f8679c
> Signed-off-by: Qianghua Wang <qianghua.wang@senarytech.com>
[Severity: Low]
The Fixes: trailer is missing the quoted commit subject. Should it be:
Fixes: 12d9c9f8679c ("ASoC: codecs: add SN624x SDCA SoundWire driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117024623.2122935-1-qianghua.wang@senarytech.com?part=1
prev parent reply other threads:[~2026-11-17 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 1:35 [PATCH] ASoC: sn624x: honor ACPI DisCo when MIC SDCA function is absent Qianghua Wang
2026-11-17 1:51 ` sashiko-bot
2026-11-17 2:46 ` [PATCH v2] ASoC: sn624x: skip DMIC when ACPI DisCo has no MIC function Qianghua Wang
2026-11-17 3:02 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218111@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=qianghua.wang@senarytech.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox