Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sreeraj S Kurup" <sreekuttan2156239@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: dmaengine: Check DMA submission errors
Date: Thu, 19 Nov 2026 07:16:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-222552@kernel.org> (raw)
In-Reply-To: <20261119071043.2943-1-sreekuttan2156239@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: dmaengine: missing Fixes trailer for dmaengine_submit()
  error check
--

commit 66f30a85918defe781d5eb22843181f804a52ee1
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: dmaengine: Check DMA submission errors
>
> The dmaengine_pcm_prepare_and_submit() function does not check
> the return value of dmaengine_submit().
>
> dmaengine_submit() can return a negative DMA cookie if the
> submission fails. However, the function currently returns
> success unconditionally.
>
> This makes the PCM trigger path believe that DMA has been
> successfully submitted, even when the submission has failed.
>
> Use dma_submit_error() to check the returned DMA cookie and
> propagate the error to the caller.
>
> This ensures that DMA submission failures are properly
> reported instead of allowing the PCM stream to continue
> as if the DMA transfer had started successfully.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
Since this fixes the unchecked dmaengine_submit() return value in
dmaengine_pcm_prepare_and_submit(), should it include:

  Fixes: e7f73a161356 ("ASoC: Add dmaengine PCM helper functions")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119071043.2943-1-sreekuttan2156239@gmail.com?part=1

      reply	other threads:[~2026-11-19  7:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  7:10 [PATCH] ALSA: dmaengine: Check DMA submission errors Sreeraj S Kurup
2026-11-19  7:16 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222552@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox