Linux Sound subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sreeraj S Kurup" <sreekuttan2156239@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: memalloc: Fix DMA allocation retry cleanup
Date: Thu, 19 Nov 2026 10:25:49 +0000	[thread overview]
Message-ID: <sashiko-outbox-222951@kernel.org> (raw)
In-Reply-To: <20261119100928.2740-1-sreekuttan2156239@gmail.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] ALSA: memalloc: GFP_DMA32 re-entry in do_alloc_pages() triggers
  VM_BUG_ON
- [High] ALSA: memalloc: do_alloc_pages() fails when
  dev->coherent_dma_mask is 0
- [Low] ALSA: memalloc: missing Fixes trailer in commit message
It also noticed 1 related pre-existing issue this patch does not
introduce:
- [High] ALSA: memalloc: page leak and bad GFP retry in do_alloc_pages()
  [1]
--

commit 8facdcf2ba9ef9e2a164a42b37b12089edb8eb1a
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: memalloc: Fix DMA allocation retry cleanup
> 
> do_alloc_pages() retries allocation with lower DMA zones when the
> allocated address exceeds the device's coherent DMA mask.
> 
> However, the previous allocation is not freed before retrying,
> leaking the allocated pages.
> 
> Also, if no suitable DMA zone is available, the function can return
> an allocation outside the device's DMA mask.
> 
> Free the allocated pages before retrying and return NULL when no
> suitable allocation can be obtained.
> 
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
Should this commit include a Fixes: tag for the commit that added the DMA
zone retry logic in do_alloc_pages()?

  Fixes: dd164fbfdc20 ("ALSA: memalloc: Drop special handling of GFP for CONTINUOUS allocation")

> diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
> index 5986e9b84ac0a..9458f9cbee537 100644
> --- a/sound/core/memalloc.c
> +++ b/sound/core/memalloc.c
> @@ -298,13 +298,17 @@ static void *do_alloc_pages(struct device *dev, size_t size, dma_addr_t *addr,
>  		return p;
>  	if ((*addr + size - 1) & ~dev->coherent_dma_mask) {
>  		if (IS_ENABLED(CONFIG_ZONE_DMA32) && !(gfp & GFP_DMA32)) {
> +			free_pages_exact(p, size);
>  			gfp |= GFP_DMA32;
>  			goto again;
>  		}
>  		if (IS_ENABLED(CONFIG_ZONE_DMA) && !(gfp & GFP_DMA)) {
> +			free_pages_exact(p, size);
>  			gfp = (gfp & ~GFP_DMA32) | GFP_DMA;
>  			goto again;
>  		}

[Severity: High]
This problem wasn't introduced by this patch, but when the GFP_DMA retry in
do_alloc_pages() still exceeds dev->coherent_dma_mask [1], doesn't the
first branch match !(gfp & GFP_DMA32) again because the GFP_DMA branch
cleared GFP_DMA32?

Instead of reaching the new return NULL fallback below, execution re-enters
the first branch, sets GFP_DMA | GFP_DMA32, and triggers VM_BUG_ON() on
GFP_ZONE_BAD in gfp_zone() on the next alloc_pages_exact() call.  Checking
!(gfp & (GFP_DMA32 | GFP_DMA)) in the first branch avoids re-entering it
after GFP_DMA has been tried.

> +		free_pages_exact(p, size);
> +		return NULL;
>  	}

[Severity: High]
Does returning NULL here cause do_alloc_pages() to unconditionally fail
when a caller passes a non-NULL struct device whose coherent_dma_mask is 0?

When dev->coherent_dma_mask is 0, ~dev->coherent_dma_mask is all ones, so
every retry fails the mask check and now hits this return NULL.  For
example, tascam_init_pcm() passes tascam->dev->dev.parent (a USB hub device
with coherent_dma_mask == 0) with SNDRV_DMA_TYPE_CONTINUOUS:

sound/usb/usx2y/us144mkii_pcm.c:tascam_init_pcm() {
	...
	snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
				       tascam->dev->dev.parent, 64 * 1024,
				       tascam_pcm_hw.buffer_bytes_max);
	...
}

With this regression, PCM buffer allocation for the TASCAM US-144MKII fails
with -ENOMEM.  Should do_alloc_pages() check if (!dev ||
!dev->coherent_dma_mask) before enforcing coherent_dma_mask?

[1] https://sashiko.dev/#/bug/linux-189ef083-a418-4b5d-b005-2d24356f0b93

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119100928.2740-1-sreekuttan2156239@gmail.com?part=1

      reply	other threads:[~2026-11-19 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:09 [PATCH] ALSA: memalloc: Fix DMA allocation retry cleanup Sreeraj S Kurup
2026-11-19 10:25 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222951@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox